You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/22 13:22:15 UTC
[GitHub] [tvm] Mousius opened a new pull request #9352: [TVMC][Relay] Introduce executor and runtime parameters
Mousius opened a new pull request #9352:
URL: https://github.com/apache/tvm/pull/9352
This introduces `executor` and `runtime` into the various entrypoints but also into `tvmc` as `--executor` and `--runtime`. This touchs a lot of files and I've tried to update anywhere as necessary.
Notable, executor code generators now accept the initial `IRModule` rather than creating
it themselves so it can be annotated once.
Validated the demo application continues to classify the tabby cat with
new CLI options.
Builds on https://github.com/apache/tvm/pull/9246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on a change in pull request #9352: [TVMC][Relay] Introduce executor and runtime parameters
Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on a change in pull request #9352:
URL: https://github.com/apache/tvm/pull/9352#discussion_r766195470
##########
File path: python/tvm/target/target.py
##########
@@ -623,27 +620,13 @@ def create_llvm_options(cpu_ver, config): # pylint: disable=unused-argument
args = [s.replace("=", "@") for s in llvm_options.split()]
return "--llvm-options=" + ",".join(args)
- # TVM target attributes string
- def create_tvm_options(cpu_ver, config): # pylint: disable=unused-argument
Review comment:
https://github.com/apache/tvm/pull/9695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #9352: [TVMC][Relay] Introduce executor and runtime parameters
Posted by GitBox <gi...@apache.org>.
areusch merged pull request #9352:
URL: https://github.com/apache/tvm/pull/9352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on a change in pull request #9352: [TVMC][Relay] Introduce executor and runtime parameters
Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on a change in pull request #9352:
URL: https://github.com/apache/tvm/pull/9352#discussion_r766089696
##########
File path: python/tvm/target/target.py
##########
@@ -623,27 +620,13 @@ def create_llvm_options(cpu_ver, config): # pylint: disable=unused-argument
args = [s.replace("=", "@") for s in llvm_options.split()]
return "--llvm-options=" + ",".join(args)
- # TVM target attributes string
- def create_tvm_options(cpu_ver, config): # pylint: disable=unused-argument
Review comment:
This essentially broke the `link-params` on Hexagon. You added code to transfer target attributes to the executor, but here you removed the target attributes from the `hexagon` target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org