[jira] [Commented] (HBASE-14663) HStore::close does not honor config hbase.rs.evictblocksonclose

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968221#comment-14968221 ] 

Hadoop QA commented on HBASE-14663:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12767853/HBASE-14663-v1.patch
  against master branch at commit b3afdb8de1a9fa88c553159b2d2d2aa96902a345.
  ATTACHMENT ID: 12767853

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16148//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16148//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16148//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16148//console

This message is automatically generated.

> HStore::close does not honor config hbase.rs.evictblocksonclose
> ---------------------------------------------------------------
>
>                 Key: HBASE-14663
>                 URL: https://issues.apache.org/jira/browse/HBASE-14663
>             Project: HBase
>          Issue Type: Bug
>          Components: BlockCache, regionserver
>    Affects Versions: 1.0.0
>            Reporter: Randy Fox
>            Assignee: Vladimir Rodionov
>            Priority: Minor
>         Attachments: HBASE-14663-v1.patch
>
>
> I noticed moving regions was slow and due to the wait for the bucket cache to clear.  I tried setting hbase.rs.evictblocksonclose and it did not help.
> I see the HStore::close method has evictonclose hard coded to true instead of letting the config dictate:
> // close each store file in parallel
> CompletionService<Void> completionService =
>    new ExecutorCompletionService<Void>(storeFileCloserThreadPool);
> for (final StoreFile f : result) {
>    completionService.submit(new Callable<Void>() {
>      @Override
>      public Void call() throws IOException {
>        f.closeReader(true);
>        return null;
>      }
>    });
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)