You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/12/01 16:16:56 UTC

Review Request 40822: Updated the pattern for `_teardown` authorization continuation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40822/
-----------------------------------------------------------

Review request for mesos, Greg Mann and Jie Yu.


Repository: mesos


Description
-------

Motivated by https://reviews.apache.org/r/39988/#comment167856


Diffs
-----

  src/master/http.cpp 9d729ef7f7d7ad6185934648f833e4f8a4f0a123 
  src/master/master.hpp 96951e766de32842197506504e5ac67a2caa3efe 

Diff: https://reviews.apache.org/r/40822/diff/


Testing
-------

`make check`


Thanks,

Michael Park


Re: Review Request 40822: Updated the pattern for `_teardown` authorization continuation.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40822/#review108574
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40822]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 1, 2015, 3:16 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40822/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 3:16 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Motivated by https://reviews.apache.org/r/39988/#comment167856
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 9d729ef7f7d7ad6185934648f833e4f8a4f0a123 
>   src/master/master.hpp 96951e766de32842197506504e5ac67a2caa3efe 
> 
> Diff: https://reviews.apache.org/r/40822/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 40822: Updated the pattern for `_teardown` authorization continuation.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40822/#review108545
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Dec. 1, 2015, 3:16 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40822/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 3:16 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Motivated by https://reviews.apache.org/r/39988/#comment167856
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 9d729ef7f7d7ad6185934648f833e4f8a4f0a123 
>   src/master/master.hpp 96951e766de32842197506504e5ac67a2caa3efe 
> 
> Diff: https://reviews.apache.org/r/40822/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>