[GitHub] [mina-sshd] knalli commented on pull request #241: [SSHD-1293] Fix unbinding port forwarding for auto-alloc port

[GitBox <gi...@apache.org>]

knalli commented on PR #241:
URL: https://github.com/apache/mina-sshd/pull/241#issuecomment-1233418548

   Note: The existing test `testLocalForwardingNative` isn't covering this (anymore) because the semaphore `tearDownSignal` is checked in the events (like `tornDownExplicitTunnel`) only -- and these events aren't called anymore! This is maybe a bigger issue actually and the root cause is the combined try-with-resources like
   
   ```
           try (ClientSession session = createNativeSession(listener);
                ExplicitPortForwardingTracker tracker = session.createLocalPortForwardingTracker(new SshdSocketAddress("", 0),
                        new SshdSocketAddress(TEST_LOCALHOST, echoPort))) {
   ```
   
   Closing the session will "destroy" everything, but there is no check if the destroy has happen after closing the tracker only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org