You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "aditya-nambiar (via GitHub)" <gi...@apache.org> on 2024/05/10 22:18:27 UTC
[PR] s3 region: Enable buckets that contain periods in their name for fetc… [arrow-rs]
aditya-nambiar opened a new pull request, #5747:
URL: https://github.com/apache/arrow-rs/pull/5747
…hing region
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] s3 region: Enable buckets that contain periods in their name for fetc… [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5747:
URL: https://github.com/apache/arrow-rs/pull/5747#issuecomment-2173899520
Marking as draft while feedback (need for a test) is addressed. Please mark it as ready for review when it is ready for another look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] s3 region: Enable buckets that contain periods in their name for fetc… [arrow-rs]
Posted by "garyhuntddn (via GitHub)" <gi...@apache.org>.
garyhuntddn commented on PR #5747:
URL: https://github.com/apache/arrow-rs/pull/5747#issuecomment-2146677677
Just a thought - I note you’ve included a trailing / in the revised endpoint url.
If I’m reading [sdk/aws-smithy-runtime/src/client/endpoint.rs](https://github.com/awslabs/aws-sdk-rust/blob/main/sdk/aws-smithy-runtime/src/client/endpoint.rs) correctly then that trailing slash will get removed, so it would be better without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] s3 region: Enable buckets that contain periods in their name for fetc… [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed pull request #5747: s3 region: Enable buckets that contain periods in their name for fetc…
URL: https://github.com/apache/arrow-rs/pull/5747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] s3 region: Enable buckets that contain periods in their name for fetc… [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #5747:
URL: https://github.com/apache/arrow-rs/pull/5747#issuecomment-2400582758
Closing as this PR has been inactive for a while
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] s3 region: Enable buckets that contain periods in their name for fetc… [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #5747:
URL: https://github.com/apache/arrow-rs/pull/5747#issuecomment-2105634324
Could we possibly get a test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org