[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6565: Core: View history entry core implementation

[GitBox <gi...@apache.org>]

jackye1995 commented on code in PR #6565:
URL: https://github.com/apache/iceberg/pull/6565#discussion_r1067210433


##########
core/src/test/resources/ViewHistoryEntry.json:
##########
@@ -0,0 +1,4 @@
+{

Review Comment:
   I think the resources are reserved for full JSON files that might be stored in Iceberg, like table metadata. For specific objects inside the JSON file we can just use hard-coded strings for testing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org