[GitHub] [thrift] Jimexist commented on a diff in pull request #2561: THRIFT-5553: java library to use newer gradle API

[GitBox <gi...@apache.org>]

Jimexist commented on code in PR #2561:
URL: https://github.com/apache/thrift/pull/2561#discussion_r849019086


##########
lib/java/gradle/environment.gradle:
##########
@@ -64,14 +64,14 @@ repositories {
 }
 
 dependencies {
-    compile "org.slf4j:slf4j-api:${slf4jVersion}"
-    compile "org.apache.httpcomponents:httpclient:${httpclientVersion}"
-    compile "org.apache.httpcomponents:httpcore:${httpcoreVersion}"
-    compile "javax.servlet:javax.servlet-api:${servletVersion}"
-    compile "javax.annotation:javax.annotation-api:${javaxAnnotationVersion}"
-    compile "org.apache.commons:commons-lang3:3.12.0"
+    implementation "org.slf4j:slf4j-api:${slf4jVersion}"
+    implementation "org.apache.httpcomponents:httpclient:${httpclientVersion}"
+    implementation "org.apache.httpcomponents:httpcore:${httpcoreVersion}"
+    implementation "javax.servlet:javax.servlet-api:${servletVersion}"
+    implementation "javax.annotation:javax.annotation-api:${javaxAnnotationVersion}"
+    implementation "org.apache.commons:commons-lang3:3.12.0"
 
-    testCompile "junit:junit:${junitVersion}"
-    testCompile "org.mockito:mockito-all:${mockitoVersion}"
-    testRuntime "org.slf4j:slf4j-log4j12:${slf4jVersion}"
+    testImplementation "junit:junit:${junitVersion}"
+    testImplementation "org.mockito:mockito-all:${mockitoVersion}"
+    testRuntimeOnly "org.slf4j:slf4j-log4j12:${slf4jVersion}"

Review Comment:
   ```suggestion
       testRuntime"org.slf4j:slf4j-log4j12:${slf4jVersion}"
   ```



##########
lib/java/gradle/functionalTests.gradle:
##########
@@ -59,18 +59,18 @@ shadowJar {
     // make sure the runners are created when this runs
     dependsOn 'generateRunnerScriptForClient', 'generateRunnerScriptForServer', 'generateRunnerScriptForNonblockingServer', 'generateRunnerScriptForTServletServer'
 
-    baseName = 'functionalTest'
-    destinationDir = file("$buildDir/functionalTestJar")
+    archiveBaseName = 'functionalTest'
+    destinationDirectory = file("$buildDir/functionalTestJar")
     classifier = null
 
     // We do not need a version number for this internal jar
-    version = null
+    archiveVersion = null
 
     // Bundle the complete set of unit test classes including generated code
     // and the runtime dependencies in one JAR to expedite execution.
     from sourceSets.test.output
     from sourceSets.crossTest.output
-    configurations = [project.configurations.testRuntime]
+    configurations = [project.configurations.testRuntimeOnly]

Review Comment:
   ```suggestion
       configurations = [project.configurations.testRuntime]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org