You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/12/16 06:22:53 UTC
[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2820: Loan account external events with repayment schedule
josehernandezfintecheandomx opened a new pull request, #2820:
URL: https://github.com/apache/fineract/pull/2820
## Description
The Loan Account Repayment schedule is not included in external event when approving or disburse a Loan
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2820: Loan account external events with repayment schedule
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2820:
URL: https://github.com/apache/fineract/pull/2820#issuecomment-1354409233
@josehernandezfintecheandomx you can use https://issues.apache.org/jira/browse/FINERACT-1734 as a JIRA ticket for the PR title and the commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2820: FINERACT-1838: Loan account external events with repayment schedule
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2820:
URL: https://github.com/apache/fineract/pull/2820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2820: Loan account external events with repayment schedule
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2820:
URL: https://github.com/apache/fineract/pull/2820#discussion_r1050833813
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/serializer/loan/LoanBusinessEventSerializer.java:
##########
@@ -46,6 +48,9 @@ public <T> boolean canSerialize(BusinessEvent<T> event) {
protected <T> ByteBufferSerializable toAvroDTO(BusinessEvent<T> rawEvent) {
LoanBusinessEvent event = (LoanBusinessEvent) rawEvent;
LoanAccountData data = service.retrieveOne(event.get().getId());
+ if (event instanceof LoanApprovedBusinessEvent || event instanceof LoanDisbursalBusinessEvent) {
Review Comment:
This is not gonna fly. Either let's create a specific Serializer for these 2 events and mark it as priority. An example for that is `LoanChargeDeletedBusinessEventSerializer`
Or, rather fetch all the data for every LoanBusinessEvent (including the repayment schedule data).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2820: FINERACT-1838: Loan account external events with repayment schedule
Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on code in PR #2820:
URL: https://github.com/apache/fineract/pull/2820#discussion_r1050949393
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/serializer/loan/LoanBusinessEventSerializer.java:
##########
@@ -46,6 +48,9 @@ public <T> boolean canSerialize(BusinessEvent<T> event) {
protected <T> ByteBufferSerializable toAvroDTO(BusinessEvent<T> rawEvent) {
LoanBusinessEvent event = (LoanBusinessEvent) rawEvent;
LoanAccountData data = service.retrieveOne(event.get().getId());
+ if (event instanceof LoanApprovedBusinessEvent || event instanceof LoanDisbursalBusinessEvent) {
Review Comment:
Done, It was set for every LoanBusinessEvent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2820: FINERACT-1838: Loan account external events with repayment schedule
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2820:
URL: https://github.com/apache/fineract/pull/2820#discussion_r1051179269
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/serializer/loan/LoanBusinessEventSerializer.java:
##########
@@ -46,6 +46,7 @@ public <T> boolean canSerialize(BusinessEvent<T> event) {
protected <T> ByteBufferSerializable toAvroDTO(BusinessEvent<T> rawEvent) {
LoanBusinessEvent event = (LoanBusinessEvent) rawEvent;
LoanAccountData data = service.retrieveOne(event.get().getId());
+ data = service.fetchRepaymentScheduleData(data);
Review Comment:
@josehernandezfintecheandomx do you think we can get this data with the retrieveOne call directly (so like extending the native query)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org