You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "mkhawam (via GitHub)" <gi...@apache.org> on 2026/07/22 17:14:13 UTC
[PR] GUACAMOLE-2306: Add support for the RDPSND Wave2 (SNDC_WAVE2) PDU. [guacamole-server]
mkhawam opened a new pull request, #696:
URL: https://github.com/apache/guacamole-server/pull/696
Modern Windows RDP servers may transmit audio using the single-PDU Wave2 (SNDC_WAVE2) form rather than the legacy WaveInfo/Wave pair. Per MS-RDPEA, a server uses Wave2 only when both the client and server advertise RDPSND protocol version 8 or higher. Guacamole previously advertised version 6 and had no SNDC_WAVE2 handler, so Wave2 could not be negotiated, and any Wave2 PDU that did arrive was silently dropped (no audio decoded and no Wave Confirmation returned, which stalls the server's audio stream).
This advertises client version 8 and adds a handler that decodes the self-contained Wave2 audio block, plays it, and acknowledges it via a Wave Confirmation PDU. The legacy WaveInfo/Wave path is retained for servers negotiating a lower version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2306: Add support for the RDPSND Wave2 (SNDC_WAVE2) PDU. [guacamole-server]
Posted by "clhedrick (via GitHub)" <gi...@apache.org>.
clhedrick commented on PR #696:
URL: https://github.com/apache/guacamole-server/pull/696#issuecomment-5059748046
It's not obvous from this description, but this patch is needed to make audio work with Gnome Remote Desktop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2306: Add support for the RDPSND Wave2 (SNDC_WAVE2) PDU. [guacamole-server]
Posted by "necouchman (via GitHub) via dev" <de...@guacamole.apache.org>.
necouchman closed pull request #696: GUACAMOLE-2306: Add support for the RDPSND Wave2 (SNDC_WAVE2) PDU.
URL: https://github.com/apache/guacamole-server/pull/696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2306: Add support for the RDPSND Wave2 (SNDC_WAVE2) PDU. [guacamole-server]
Posted by "necouchman (via GitHub) via dev" <de...@guacamole.apache.org>.
necouchman commented on PR #696:
URL: https://github.com/apache/guacamole-server/pull/696#issuecomment-6543703174
Sorry @mkhawam, I think you had your PR in, first, and I was working down the list and ended up merging #729, which looks more or less identical. Support for this has been merged into `main` for the 1.7.0 release (no date/estimate at this point).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org