You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/05/05 18:00:32 UTC

[GitHub] [accumulo] jmark99 opened a new pull request #1604: Remove non-looping 'while' loops.

jmark99 opened a new pull request #1604:
URL: https://github.com/apache/accumulo/pull/1604


   ReplicationClient.java and ThriftServerBindsBeforeZooKeeperLockIT.java contain instances of 'while' loops which never loop.
   
   In the case of ReplicationClient, the loop is always entered but either returns or throws an exception.
   
   ThriftServerBindsBeforeZooKepperLockIT contains three 'while' blocks that never loop. Each of the outer 'while' blocks contain another 'while' which does loop until a condition is met resulting in a  'return' case being satisfied.
   
   The outer loop does not appear to be necessary in each of these cases. These loops have been removed to increase readability of the code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org