You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (Commented) (JIRA)" <de...@myfaces.apache.org> on 2012/02/20 03:00:34 UTC
[jira] [Commented] (MYFACES-3463) Refactor UIRepeat code to
implement PSS algorithm like UIData and fix state behavior
[ https://issues.apache.org/jira/browse/MYFACES-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211632#comment-13211632 ]
Leonardo Uribe commented on MYFACES-3463:
-----------------------------------------
I reviewed the code and created a patch, taking what's necessary from UIData. At the end the code has two differences:
- State for rows (rowState) was saved into the state. This is not necessary because the information for EditableValueHolder is usually send to the client and then go back to the server. UIData do that and there is no reason why UIRepeat cannot do it.
- The condition for reset model if a validation occur is based only on the messages related to components in UIRepeat. In UIData, the condition is different. To solve MYFACES-3415 it is preferred to do the same as UIData does. Anyway, this should be discussed on the EG, because the condition is not very clear and there is other issue (MYFACES-3326) that suggest this condition should be enhanced.
If no objections I'll commit the code soon (on 2.0.x and 2.1.x branches)
> Refactor UIRepeat code to implement PSS algorithm like UIData and fix state behavior
> ------------------------------------------------------------------------------------
>
> Key: MYFACES-3463
> URL: https://issues.apache.org/jira/browse/MYFACES-3463
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-314
> Affects Versions: 2.0.12, 2.1.6
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Attachments: MYFACES-3463-1.patch
>
>
> Right now, the code in org.apache.myfaces.view.facelets.component.UIRepeat has not been reviewed more than to fix issues related to JSF 2 spec. It works, but it can be done better.
> The code has the following opportunities:
> - Implement PSS algorithm, to prevent store data in the state.
> - The algorithm used in UIData to handle state is better.
> - Fix MYFACES-3415
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira