You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2023/01/31 07:27:18 UTC

[GitHub] [doris] HappenLee opened a new pull request, #16287: [Refactor][function] Rewrite the function elt

HappenLee opened a new pull request, #16287:
URL: https://github.com/apache/doris/pull/16287

   # Proposed changes
   
       qt_sql "select c1, c2, elt(c1, c2) from (select number as c1, 'varchar' as c2 from numbers('number'='5') where number > 0) a;"
   
   get error result:
   
   ```
   +------+---------+-----------------+
   | c1   | c2      | elt(`c1`, `c2`) |
   +------+---------+-----------------+
   |    1 | varchar | varchar         |
   |    2 | varchar | varchar         |
   |    3 | varchar | varchar         |
   |    4 | varchar | varchar         |
   +------+---------+-----------------+
   
   ```
   
   after fix:
   
   ```
   +------+---------+-----------------+
   | c1   | c2      | elt(`c1`, `c2`) |
   +------+---------+-----------------+
   |    1 | varchar | varchar         |
   |    2 | varchar | NULL            |
   |    3 | varchar | NULL            |
   |    4 | varchar | NULL            |
   +------+---------+-----------------+
   
   ```
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #16287: [Refactor](function) Rewrite the function elt

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #16287:
URL: https://github.com/apache/doris/pull/16287#issuecomment-1410103474

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 35.95 seconds
    load time: 491 seconds
    storage size: 17123121856 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230131102201_clickbench_pr_87807.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #16287: [Refactor](function) Rewrite the function elt

Posted by github-actions.
github-actions[bot] commented on PR #16287:
URL: https://github.com/apache/doris/pull/16287#issuecomment-1409920533

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #16287: [Refactor][function] Rewrite the function elt

Posted by github-actions.
github-actions[bot] commented on PR #16287:
URL: https://github.com/apache/doris/pull/16287#issuecomment-1409892995

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] Gabriel39 merged pull request #16287: [Refactor](function) Rewrite the function elt

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #16287:
URL: https://github.com/apache/doris/pull/16287


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org