You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2013/05/08 06:07:33 UTC

git commit: Changed the signal handler to use LOG(WARNING), corrected a comment.

Updated Branches:
  refs/heads/master f50bd38fc -> b36863069


Changed the signal handler to use LOG(WARNING), corrected a comment.

Review: https://reviews.apache.org/r/10990


Project: http://git-wip-us.apache.org/repos/asf/incubator-mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-mesos/commit/b3686306
Tree: http://git-wip-us.apache.org/repos/asf/incubator-mesos/tree/b3686306
Diff: http://git-wip-us.apache.org/repos/asf/incubator-mesos/diff/b3686306

Branch: refs/heads/master
Commit: b36863069960936c19d8d40d472c388a9b840499
Parents: f50bd38
Author: Benjamin Mahler <bm...@twitter.com>
Authored: Tue May 7 20:58:38 2013 -0700
Committer: Benjamin Mahler <bm...@twitter.com>
Committed: Tue May 7 21:07:13 2013 -0700

----------------------------------------------------------------------
 src/logging/logging.cpp |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-mesos/blob/b3686306/src/logging/logging.cpp
----------------------------------------------------------------------
diff --git a/src/logging/logging.cpp b/src/logging/logging.cpp
index 535bbae..c36f7fa 100644
--- a/src/logging/logging.cpp
+++ b/src/logging/logging.cpp
@@ -151,8 +151,8 @@ string argv0;
 
 void handler(int signal)
 {
-  std::cerr << "Received signal '" << strsignal(signal)
-            << "', escalating to SIGABRT" << std::endl;
+  LOG(WARNING) << "Received signal '" << strsignal(signal)
+               << "', escalating to SIGABRT";
   raise(SIGABRT);
 }
 
@@ -207,7 +207,7 @@ void initialize(
     // of its lovely information.
     struct sigaction action;
     action.sa_handler = handler;
-    // Block all additional signals while in the handler.
+    // Do not block additional signals while in the handler.
     sigemptyset(&action.sa_mask);
     action.sa_flags = 0;
     if (sigaction(SIGPIPE, &action, NULL) < 0) {