You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bigtop.apache.org by Josh Elser <jo...@gmail.com> on 2014/06/09 20:22:52 UTC

Re: Review Request 21293: Adding Apache Accumulo to Apache Bigtop

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21293/#review45098
-----------------------------------------------------------


Two very minor removals, both of which shouldn't break anything if this were committed as-is. LGTM!


bigtop-packages/src/common/accumulo/conf/accumulo-site.xml
<https://reviews.apache.org/r/21293/#comment79760>

    I think this line is unnecessary (also is missing the '*') as the following line will encompass this one.



bigtop-packages/src/common/accumulo/install_accumulo.sh
<https://reviews.apache.org/r/21293/#comment79761>

    This can be removed as it's not referenced anywhere.


- Josh Elser


On May 9, 2014, 11:31 p.m., Sean Mackrory wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21293/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 11:31 p.m.)
> 
> 
> Review request for bigtop.
> 
> 
> Bugs: BIGTOP-1175
>     https://issues.apache.org/jira/browse/BIGTOP-1175
> 
> 
> Repository: bigtop
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION 
>   bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION 
>   bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION 
>   bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION 
>   bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION 
>   bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION 
>   bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml PRE-CREATION 
>   bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION 
>   bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION 
>   bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION 
>   bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION 
>   bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION 
>   bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION 
>   bigtop-packages/src/common/hadoop/init-hcfs.json d8825aa33839b88d09ee928e0be83c46e88a2992 
>   bigtop-packages/src/common/hadoop/init-hdfs.sh 3a5fe361dd56308f465a52214835a42900a618cd 
>   bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/compat PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/control PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/copyright PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/rules PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/source/format PRE-CREATION 
>   bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION 
>   bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION 
>   bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION 
>   bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION 
>   bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION 
>   bigtop-packages/src/templates/init.d.tmpl 57923240c2402c66b758790fcd8522186827f836 
>   bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960 
> 
> Diff: https://reviews.apache.org/r/21293/diff/
> 
> 
> Testing
> -------
> 
> See JIRA
> 
> 
> Thanks,
> 
> Sean Mackrory
> 
>

Re: Review Request 21293: Adding Apache Accumulo to Apache Bigtop

Posted by Sean Mackrory <ma...@gmail.com>.


> On June 9, 2014, 6:22 p.m., Josh Elser wrote:
> > bigtop-packages/src/common/accumulo/install_accumulo.sh, line 163
> > <https://reviews.apache.org/r/21293/diff/1/?file=577870#file577870line163>
> >
> >     This can be removed as it's not referenced anywhere.

Yes - I believe that's vestigial from a previous version of Accumulo, which I originally started the packaging on.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21293/#review45098
-----------------------------------------------------------


On May 9, 2014, 11:31 p.m., Sean Mackrory wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21293/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 11:31 p.m.)
> 
> 
> Review request for bigtop.
> 
> 
> Bugs: BIGTOP-1175
>     https://issues.apache.org/jira/browse/BIGTOP-1175
> 
> 
> Repository: bigtop
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION 
>   bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION 
>   bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION 
>   bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION 
>   bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION 
>   bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION 
>   bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml PRE-CREATION 
>   bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION 
>   bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION 
>   bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION 
>   bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION 
>   bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION 
>   bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION 
>   bigtop-packages/src/common/hadoop/init-hcfs.json d8825aa33839b88d09ee928e0be83c46e88a2992 
>   bigtop-packages/src/common/hadoop/init-hdfs.sh 3a5fe361dd56308f465a52214835a42900a618cd 
>   bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/compat PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/control PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/copyright PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/rules PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION 
>   bigtop-packages/src/deb/accumulo/source/format PRE-CREATION 
>   bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION 
>   bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION 
>   bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION 
>   bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION 
>   bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION 
>   bigtop-packages/src/templates/init.d.tmpl 57923240c2402c66b758790fcd8522186827f836 
>   bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960 
> 
> Diff: https://reviews.apache.org/r/21293/diff/
> 
> 
> Testing
> -------
> 
> See JIRA
> 
> 
> Thanks,
> 
> Sean Mackrory
> 
>