You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/03/10 01:17:34 UTC
[GitHub] [logging-log4cxx] stephen-webb opened a new pull request #21: Add
support for building log4cxx as a statically linked library on Windows
stephen-webb opened a new pull request #21: Add support for building log4cxx as a statically linked library on Windows
URL: https://github.com/apache/logging-log4cxx/pull/21
Replacement for PR #20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4cxx] ams-tschoening merged pull request #21: Add
support for building log4cxx as a statically linked library on Windows
Posted by GitBox <gi...@apache.org>.
ams-tschoening merged pull request #21: Add support for building log4cxx as a statically linked library on Windows
URL: https://github.com/apache/logging-log4cxx/pull/21
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4cxx] ams-tschoening commented on issue #21: Add
support for building log4cxx as a statically linked library on Windows
Posted by GitBox <gi...@apache.org>.
ams-tschoening commented on issue #21: Add support for building log4cxx as a statically linked library on Windows
URL: https://github.com/apache/logging-log4cxx/pull/21#issuecomment-605838327
Any reason why `-DAPU_STATIC` and `-DAPR_STATIC` are not documented with something like `=off|on` , like `-DBUILD_SHARED_LIBS` is? Does this work differently or ...?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull
request #21: Add support for building log4cxx as a statically linked
library on Windows
Posted by GitBox <gi...@apache.org>.
ams-tschoening commented on a change in pull request #21: Add support for building log4cxx as a statically linked library on Windows
URL: https://github.com/apache/logging-log4cxx/pull/21#discussion_r390155388
##########
File path: src/site/apt/building/cmake.apt
##########
@@ -50,6 +50,12 @@ $ sudo make install
*------------------------+---------------------------------------------------------------------------------------------+
| -DBUILD_SHARED_LIBS=off| Build log4cxx as a static library. A dynamically linked log4cxx library is built by default.|
| | Any compilation unit that includes a log4cxx header must define LOG4CXX_STATIC. |
+*------------------------+---------------------------------------------------------------------------------------------+
+| -DAPU_STATIC | Link to the APR-Util static library. By default, the log4cxx shared library is linked to the|
Review comment:
Any reason why `-DAPU_STATIC` and `-DAPR_STATIC` are not documented with something like `=off|on` , like `-DBUILD_SHARED_LIBS` is? Does this work differently or ...?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4cxx] ams-tschoening commented on issue #21: Add
support for building log4cxx as a statically linked library on Windows
Posted by GitBox <gi...@apache.org>.
ams-tschoening commented on issue #21: Add support for building log4cxx as a statically linked library on Windows
URL: https://github.com/apache/logging-log4cxx/pull/21#issuecomment-605877990
Then please add `=yes|no|on|off` as necessary/useful for `-D*_STATIC`, so that its in line with the other documented options. Afterwards I'm going to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4cxx] stephen-webb commented on issue #21: Add support
for building log4cxx as a statically linked library on Windows
Posted by GitBox <gi...@apache.org>.
stephen-webb commented on issue #21: Add support for building log4cxx as a statically linked library on Windows
URL: https://github.com/apache/logging-log4cxx/pull/21#issuecomment-605849220
No, they work the same, except the Build shared is on by default. The =on
does no more than the existence of a definition.
On Mon, Mar 30, 2020, 6:44 PM Thorsten Schöning <no...@github.com>
wrote:
> *@ams-tschoening* requested changes on this pull request.
> ------------------------------
>
> In src/site/apt/building/cmake.apt
> <https://github.com/apache/logging-log4cxx/pull/21#discussion_r390155388>:
>
> > @@ -50,6 +50,12 @@ $ sudo make install
> *------------------------+---------------------------------------------------------------------------------------------+
> | -DBUILD_SHARED_LIBS=off| Build log4cxx as a static library. A dynamically linked log4cxx library is built by default.|
> | | Any compilation unit that includes a log4cxx header must define LOG4CXX_STATIC. |
> +*------------------------+---------------------------------------------------------------------------------------------+
> +| -DAPU_STATIC | Link to the APR-Util static library. By default, the log4cxx shared library is linked to the|
>
> Any reason why -DAPU_STATIC and -DAPR_STATIC are not documented with
> something like =off|on , like -DBUILD_SHARED_LIBS is? Does this work
> differently or ...?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/logging-log4cxx/pull/21#pullrequestreview-371753644>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ANLOSDWPWKXFOJOFOJQBYKTRKBEUPANCNFSM4LEUWTVQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4cxx] stephen-webb commented on issue #21: Add support
for building log4cxx as a statically linked library on Windows
Posted by GitBox <gi...@apache.org>.
stephen-webb commented on issue #21: Add support for building log4cxx as a statically linked library on Windows
URL: https://github.com/apache/logging-log4cxx/pull/21#issuecomment-605873078
Correction, =yes is equivalent to existence of a definition
On Mon, Mar 30, 2020, 7:10 PM Stephen Webb <sw...@gmail.com> wrote:
> No, they work the same, except the Build shared is on by default. The =on
> does no more than the existence of a definition.
>
>
> On Mon, Mar 30, 2020, 6:44 PM Thorsten Schöning <no...@github.com>
> wrote:
>
>> *@ams-tschoening* requested changes on this pull request.
>> ------------------------------
>>
>> In src/site/apt/building/cmake.apt
>> <https://github.com/apache/logging-log4cxx/pull/21#discussion_r390155388>
>> :
>>
>> > @@ -50,6 +50,12 @@ $ sudo make install
>> *------------------------+---------------------------------------------------------------------------------------------+
>> | -DBUILD_SHARED_LIBS=off| Build log4cxx as a static library. A dynamically linked log4cxx library is built by default.|
>> | | Any compilation unit that includes a log4cxx header must define LOG4CXX_STATIC. |
>> +*------------------------+---------------------------------------------------------------------------------------------+
>> +| -DAPU_STATIC | Link to the APR-Util static library. By default, the log4cxx shared library is linked to the|
>>
>> Any reason why -DAPU_STATIC and -DAPR_STATIC are not documented with
>> something like =off|on , like -DBUILD_SHARED_LIBS is? Does this work
>> differently or ...?
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/logging-log4cxx/pull/21#pullrequestreview-371753644>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ANLOSDWPWKXFOJOFOJQBYKTRKBEUPANCNFSM4LEUWTVQ>
>> .
>>
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services