You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/05 08:02:00 UTC

[GitHub] [airflow] aranjanthakur opened a new issue #10166: Add capability to specify gunicorn access log format for airflow webserver

aranjanthakur opened a new issue #10166:
URL: https://github.com/apache/airflow/issues/10166


   **Description**
   
   Currently gunicorn access logs don't include response time. In gunicorn we can specify access-logformat to include response time. When running airflow webserver we should be able to specify this format by either defining it in airflow.cfg or passing as argument in airflow webserver command.
   
   **Use case / motivation**
   
   We want to monitor airlfow response time.
   
   **Related Issues**
   
   None
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #10166: Add capability to specify gunicorn access log format for airflow webserver

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #10166:
URL: https://github.com/apache/airflow/issues/10166#issuecomment-669045673


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] aranjanthakur commented on issue #10166: Add capability to specify gunicorn access log format for airflow webserver

Posted by GitBox <gi...@apache.org>.
aranjanthakur commented on issue #10166:
URL: https://github.com/apache/airflow/issues/10166#issuecomment-671048749


   Hi @mik-laj , I have made the required changes. Could you please guide how I can test it?
   I have run integration tests in breeze env. I want to build it locally and test the webserver.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] aranjanthakur commented on issue #10166: Add capability to specify gunicorn access log format for airflow webserver

Posted by GitBox <gi...@apache.org>.
aranjanthakur commented on issue #10166:
URL: https://github.com/apache/airflow/issues/10166#issuecomment-683415872


   @mik-laj I have added the test cases, could you please review the changes 
   https://github.com/apache/airflow/pull/10261
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] aranjanthakur commented on issue #10166: Add capability to specify gunicorn access log format for airflow webserver

Posted by GitBox <gi...@apache.org>.
aranjanthakur commented on issue #10166:
URL: https://github.com/apache/airflow/issues/10166#issuecomment-671049327


   https://github.com/apache/airflow/pull/10261 
   Please take a look


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj edited a comment on issue #10166: Add capability to specify gunicorn access log format for airflow webserver

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #10166:
URL: https://github.com/apache/airflow/issues/10166#issuecomment-669077240


   Hi. Would you like to prepare a PR to implement this feature? I will gladly support you if you have any questions.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #10166: Add capability to specify gunicorn access log format for airflow webserver

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10166:
URL: https://github.com/apache/airflow/issues/10166#issuecomment-671048826


   Can you create a PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj edited a comment on issue #10166: Add capability to specify gunicorn access log format for airflow webserver

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #10166:
URL: https://github.com/apache/airflow/issues/10166#issuecomment-671048826


   Can you create a draft pull request?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj closed issue #10166: Add capability to specify gunicorn access log format for airflow webserver

Posted by GitBox <gi...@apache.org>.
mik-laj closed issue #10166:
URL: https://github.com/apache/airflow/issues/10166


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] aranjanthakur commented on issue #10166: Add capability to specify gunicorn access log format for airflow webserver

Posted by GitBox <gi...@apache.org>.
aranjanthakur commented on issue #10166:
URL: https://github.com/apache/airflow/issues/10166#issuecomment-686408236


   @turbaszek @mik-laj let me know if any other changes are required for this feature add


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #10166: Add capability to specify gunicorn access log format for airflow webserver

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10166:
URL: https://github.com/apache/airflow/issues/10166#issuecomment-669077240


   Hi. Would you like to prepare a PR to fix this problem? I will gladly support you if you have any questions.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org