You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/04/28 19:18:39 UTC
[GitHub] flink pull request #3800: [FLINK-6414] [build] Use scala.binary.version in p...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3800
[FLINK-6414] [build] Use scala.binary.version in place of change-scala-version.sh
Use scala.binary.version as defined in the parent POM and remove the script to swap scala version identifiers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 6414_use_scala_binary_version_in_place_of_change_scala_version_sh
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3800.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3800
----
commit 6d0ca2f9ddf3d33f9f2953242234e5e053cb00b5
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-04-27T18:43:18Z
[FLINK-6414] [build] Use scala.binary.version in place of change-scala-version.sh
Use scala.binary.version as defined in the parent POM and remove the
script to swap scala version identifiers.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3800: [FLINK-6414] [build] Use scala.binary.version in place of...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3800
@rmetzger I have tried to put this into 1.3 as well - seems to work...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3800: [FLINK-6414] [build] Use scala.binary.version in place of...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3800
@greghogan I think we should keep the `force-shading` approach to have every project pass through the shade plugin, for various reasons. Resolving variables (as required here) is one of them, but filtering of configuration files, signature files, etc. are also very good reasons. Also, there may be "single use" shaded dependencies in non-scala projects, which could still be shaded on the fly in the using project directly (netty in flink-runtime would be such a case).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3800: [FLINK-6414] [build] Use scala.binary.version in p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3800
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3800: [FLINK-6414] [build] Use scala.binary.version in place of...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3800
Thinking more about this, I am +1 to the approach here.
Seems easier to maintain, compared to having a complicated script.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3800: [FLINK-6414] [build] Use scala.binary.version in place of...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3800
I remember initially this did not work, because the variables where not properly resolved.
It probably works now, because we force the shade plugin to be evaluated in each project (via the `force-shading` dependency). The shade plugin has the nice side effect of resolving variables.
The thing we should be aware of here is that by going with this change, we must keep the `force-shading` hack. In some sense this PR brings the "force-shading" approach to conclusion.
I remember that there was an alternate suggestion initially to not do the force-shading and rather have a more elaborate `change-scala-version.sh` script instead.
Just bringing this up so we are aware of the context/implications. I am okay with either approach.
@rmetzger What is you take here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3800: [FLINK-6414] [build] Use scala.binary.version in place of...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3800
Merging this for 1.4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3800: [FLINK-6414] [build] Use scala.binary.version in place of...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3800
I think it should be fine to merge this (for 1.4 only please :)). The problem was that in some fields the variable substitution did not work. Maven was still able to resolve it, but sbt was failing to retrieve the dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3800: [FLINK-6414] [build] Use scala.binary.version in place of...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3800
@StephanEwen does the recent discussion on packaging shaded dependencies mean that `force-shading` will go away? Or do we keep that even if dependencies are no longer being shaded? Or will only some shaded dependencies (the most problematic) be provided?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---