You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/04 11:27:26 UTC

[GitHub] [kafka] jeqo commented on a change in pull request #10294: KAFKA-12450: Remove deprecated methods from ReadOnlyWindowStore

jeqo commented on a change in pull request #10294:
URL: https://github.com/apache/kafka/pull/10294#discussion_r625703299



##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CompositeReadOnlyWindowStore.java
##########
@@ -68,10 +65,9 @@ public V fetch(final K key, final long time) {
     }
 
     @Override
-    @Deprecated
     public WindowStoreIterator<V> fetch(final K key,
-                                        final long timeFrom,
-                                        final long timeTo) {
+                                        final Instant timeFrom,

Review comment:
       Yes, default implementation is doing this convertion already. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org