[jira] [Commented] (CASSANDRA-9438) Repair version gating will do the wrong thing in rc/beta dev builds

["Yuki Morishita (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552509#comment-14552509 ] 

Yuki Morishita commented on CASSANDRA-9438:
-------------------------------------------

I think the easier way to fix is to ignore {{-SNAPSHOT}} part when parsing version string into {{SemanticVersion}} object.
Also we should rename the class to CassandraVersion as it is no longer dealing with semver.

> Repair version gating will do the wrong thing in rc/beta dev builds
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-9438
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9438
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Jeremiah Jordan
>            Assignee: Yuki Morishita
>             Fix For: 2.2.0 rc1
>
>
> The version check gate in AnticompactionTask will fail with -betaX-SNAPSHOT and -rcX-SNAPSHOT builds. As SystemKeyspace.getReleaseVersion will return null for those.  This means dtests and anyone else testing with dev builds will be getting the wrong repair behavior.
> [AnticompactionTask.java|https://github.com/apache/cassandra/blob/a583f70eeeada31478a55b5774ef222c55956220/src/java/org/apache/cassandra/repair/AnticompactionTask.java#L59]
> {code}
>         SemanticVersion peerVersion = SystemKeyspace.getReleaseVersion(neighbor);
>         if (peerVersion != null && peerVersion.compareTo(VERSION_CHECKER) > 0)
>         {
>             MessagingService.instance().sendRR(acr.createMessage(), neighbor, new AnticompactionCallback(this), TimeUnit.DAYS.toMillis(1), true);
>         }
>         else
>         {
>             MessagingService.instance().sendOneWay(acr.createMessage(), neighbor);
>             // immediately return after sending request
>             set(neighbor);
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)