[GitHub] [solr] risdenk commented on a diff in pull request #1320: SOLR-16641 - Fix circular task dependency for gradle.properties

["risdenk (via GitHub)" <gi...@apache.org>]

risdenk commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1092366743


##########
gradlew:
##########
@@ -163,11 +163,8 @@ fi
 
 CLASSPATH=$GRADLE_WRAPPER_JAR
 
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
-if [ ! -e "$APP_HOME/gradle.properties" ]; then
-    GRADLE_DAEMON_CTRL=--no-daemon
-fi
+# Hold on to the original arguments, don't want to pass them in when generating gradle.properties
+TASK_ARGS=$@

Review Comment:
   Not sure I understand this line with what is on lines 273 and 282 - it looks like "$@" is still used in both places? Also it doesn't look like we do the same TASK_ARGS trick for Windows if its needed?
   
   Also does $@ need to be quoted?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org