You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by "kezhuw (via GitHub)" <gi...@apache.org> on 2025/08/16 10:51:22 UTC
[PR] ZOOKEEPER-4955: [ADDENDUM] Refactor Ca, Cert and etc. so to be reusable [zookeeper]
kezhuw opened a new pull request, #2300:
URL: https://github.com/apache/zookeeper/pull/2300
This is a fixup commit to #2292. It contains only test code changes to make SSL related classes, e.g. Ca, Cert and etcd., to be reusable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4955: [ADDENDUM] Refactor Ca, Cert and etc. so to be reusable [zookeeper]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on PR #2300:
URL: https://github.com/apache/zookeeper/pull/2300#issuecomment-3229841380
> > Have you generated it with some AI?
>
> No. But I do use IntelliJ IDEA in this refactoring, not sure whether the code completions/suggestions(line by line, it will recommend you `public CertSigner withExpiration(Duration expiration) {}` or `this.expiration = expiration;`) are backed by AI.
I dunno, but it's pretty impressive how quickly you were able to create the framework. Borrowed from other project or wrote from scratch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4955: [ADDENDUM] Refactor Ca, Cert and etc. so to be reusable [zookeeper]
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #2300:
URL: https://github.com/apache/zookeeper/pull/2300#issuecomment-3224363123
@anmolnar Would you like to take a look at this ? It is a fixup commit to #2292(ZOOKEEPER-4955) and touchs only test codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4955: [ADDENDUM] Refactor Ca, Cert and etc. so to be reusable [zookeeper]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar merged PR #2300:
URL: https://github.com/apache/zookeeper/pull/2300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4955: [ADDENDUM] Refactor Ca, Cert and etc. so to be reusable [zookeeper]
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #2300:
URL: https://github.com/apache/zookeeper/pull/2300#issuecomment-3231701754
> Borrowed from other project or wrote from scratch?
From scratch. But I do write tls related tests code in rust, they probably have something in common despite the language.
https://github.com/kezhuw/zookeeper-client-rust/blob/4ae35472bf8545ee3462aaf287e9359ae8953644/src/tls/client.rs#L211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4955: [ADDENDUM] Refactor Ca, Cert and etc. so to be reusable [zookeeper]
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #2300:
URL: https://github.com/apache/zookeeper/pull/2300#issuecomment-3229220498
> Have you generated it with some AI?
No. But I do use IntelliJ IDEA in this refactoring, not sure whether the code completions/suggestions(line by line, it will recommend you `public CertSigner withExpiration(Duration expiration) {}` or `this.expiration = expiration;`) are backed by AI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org