You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/02 20:33:10 UTC
[GitHub] GabeLoins opened a new pull request #4738: [SqlLab] 1-click tab closing in SqlLab
GabeLoins opened a new pull request #4738: [SqlLab] 1-click tab closing in SqlLab
URL: https://github.com/apache/incubator-superset/pull/4738
As discussed in the #superset slack group, I felt like the general consensus was adding 1-click to close SqlLab tabs would be nice. This was also a personal pet peeve of mine.
test plan:
- create a tab
- click the x button on a tab and verify it closes
- verify clicking the rest of the tab doesn't trigger a close
- run the specs
reviewers:
@michellethomas @williaster @graceguo-supercat
cc @mistercrunch @hughhhh @fabianmenges
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services