You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/04/23 20:41:51 UTC
Review Request 20618: Added a test for testing the base set in log ZooKeeper
network.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20618/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Bugs: MESOS-1231
https://issues.apache.org/jira/browse/MESOS-1231
Repository: mesos-git
Description
-------
Followup for https://reviews.apache.org/r/20602/
See summary.
Diffs
-----
src/log/network.hpp ad9854b
src/tests/log_tests.cpp db91ef8
Diff: https://reviews.apache.org/r/20618/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 20618: Added a test for testing the base set in log
ZooKeeper network.
Posted by Jie Yu <yu...@gmail.com>.
> On April 23, 2014, 6:53 p.m., Ben Mahler wrote:
> > src/tests/log_tests.cpp, line 2011
> > <https://reviews.apache.org/r/20618/diff/1/?file=565962#file565962line2011>
> >
> > Should this test be inside an ifdef for MESOS_HAS_JAVA since that's how the include is guarded for ZooKeeperTest?
Ben, it's inside #ifdef MESOS_HAS_JAVA guard:)
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20618/#review41185
-----------------------------------------------------------
On April 23, 2014, 6:41 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20618/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 6:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1231
> https://issues.apache.org/jira/browse/MESOS-1231
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Followup for https://reviews.apache.org/r/20602/
>
> See summary.
>
>
> Diffs
> -----
>
> src/log/network.hpp ad9854b
> src/tests/log_tests.cpp db91ef8
>
> Diff: https://reviews.apache.org/r/20618/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 20618: Added a test for testing the base set in log
ZooKeeper network.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20618/#review41185
-----------------------------------------------------------
Ship it!
src/tests/log_tests.cpp
<https://reviews.apache.org/r/20618/#comment74605>
Should this test be inside an ifdef for MESOS_HAS_JAVA since that's how the include is guarded for ZooKeeperTest?
- Ben Mahler
On April 23, 2014, 6:41 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20618/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 6:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1231
> https://issues.apache.org/jira/browse/MESOS-1231
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Followup for https://reviews.apache.org/r/20602/
>
> See summary.
>
>
> Diffs
> -----
>
> src/log/network.hpp ad9854b
> src/tests/log_tests.cpp db91ef8
>
> Diff: https://reviews.apache.org/r/20618/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>