You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@yetus.apache.org by GitBox <gi...@apache.org> on 2022/04/26 14:59:43 UTC

[GitHub] [yetus] ndimiduk commented on a diff in pull request #260: YETUS-1163. Remove changelog data from config.rb

ndimiduk commented on code in PR #260:
URL: https://github.com/apache/yetus/pull/260#discussion_r858822611


##########
asf-site-src/config.rb:
##########
@@ -164,19 +144,6 @@ def convert_table(el, indent) # rubocop:disable Naming/MethodParameterName
   # instead of symlinks
   FileUtils.mkdir_p 'target/in-progress/precommit/apidocs/'
   precommit_shelldocs('target/in-progress/precommit/apidocs/', '../precommit/src/main/shell')
-  # stitch the javadoc in place

Review Comment:
   Yeah yeah simpler is better.



##########
asf-site-src/source/downloads/index.html.md.erb:
##########
@@ -37,8 +37,8 @@ third-party repositories (e.g. Maven Central) and [Docker Hub](../yetus-docker-i
 
 <%   data.versions.releases.reverse.each do | release | %>
   * <%= release %>
-    * [Release Notes](/documentation/<%= release %>/RELEASENOTES)
-    * [CHANGELOG](/documentation/<%= release %>/CHANGELOG)
+    * [Release Notes](releasenotes/<%= release %>/RELEASENOTES.<%= release %>/)

Review Comment:
   Hmm the URL change here isn't going to break existing/old links?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org