You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Nabeel Yoosuf (JIRA)" <ji...@apache.org> on 2006/04/08 13:30:23 UTC
[jira] Created: (AXIS2C-121) Log implementation does not go through
ops
Log implementation does not go through ops
------------------------------------------
Key: AXIS2C-121
URL: http://issues.apache.org/jira/browse/AXIS2C-121
Project: Axis2-C
Type: Improvement
Components: util
Environment: Linux/Windows
Reporter: Nabeel Yoosuf
Priority: Minor
The log implemenation does not go through ops; as a result of that a user cannot plug his/her log implementation to use the engine. It would be better if we can have it aleast for Linux since there's a known problem with accessing fucntions with variable no of arguments through macros in windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (AXIS2C-121) Log implementation does not go
through ops
Posted by "Samisa Abeysinghe (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2C-121?page=all ]
Samisa Abeysinghe reassigned AXIS2C-121:
----------------------------------------
Assignee: Dinesh Premalal
One should be able to plug in the logger. So this needs to be fixed.
> Log implementation does not go through ops
> ------------------------------------------
>
> Key: AXIS2C-121
> URL: http://issues.apache.org/jira/browse/AXIS2C-121
> Project: Axis2-C
> Issue Type: Improvement
> Components: util
> Environment: Linux/Windows
> Reporter: Nabeel Yoosuf
> Assigned To: Dinesh Premalal
> Priority: Minor
>
> The log implemenation does not go through ops; as a result of that a user cannot plug his/her log implementation to use the engine. It would be better if we can have it aleast for Linux since there's a known problem with accessing fucntions with variable no of arguments through macros in windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Updated: (AXIS2C-121) Log implementation does not go through
ops
Posted by "Samisa Abeysinghe (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2C-121?page=all ]
Samisa Abeysinghe updated AXIS2C-121:
-------------------------------------
Fix Version/s: 1.0.0
(was: 0.96)
> Log implementation does not go through ops
> ------------------------------------------
>
> Key: AXIS2C-121
> URL: http://issues.apache.org/jira/browse/AXIS2C-121
> Project: Axis2-C
> Issue Type: Improvement
> Components: util
> Environment: Linux/Windows
> Reporter: Nabeel Yoosuf
> Assigned To: Dinesh Premalal
> Priority: Minor
> Fix For: 1.0.0
>
>
> The log implemenation does not go through ops; as a result of that a user cannot plug his/her log implementation to use the engine. It would be better if we can have it aleast for Linux since there's a known problem with accessing fucntions with variable no of arguments through macros in windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Commented: (AXIS2C-121) Log implementation does not go
through ops
Posted by "Pim Philipse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639818#action_12639818 ]
Pim Philipse commented on AXIS2C-121:
-------------------------------------
While you're at it,
axutil_log_impl_log_user(
...
if (AXIS2_LOG_LEVEL_DEBUG <= log->level)
{
char value[AXIS2_LEN_VALUE + 1];
va_list ap;
va_start(ap, format);
AXIS2_VSNPRINTF(value, AXIS2_LEN_VALUE, format, ap);
va_end(ap);
axutil_log_impl_write_to_file(log, mutex, AXIS2_LOG_LEVEL_DEBUG,
filename, linenumber, value);
}
1: change AXIS2_LOG_LEVEL_DEBUG to AXIS2_LOG_LEVEL_USER
2: Some of the members of the enum have a misleading comment:
/** Warning level, logs only warnings */
AXIS2_LOG_LEVEL_WARNING,
which is of course not true, as axutil_log_impl_log_warning() has as condition:
if (AXIS2_LOG_LEVEL_WARNING <= log->level &&
log->level != AXIS2_LOG_LEVEL_USER)
3: I think messages with AXIS2_LOG_LEVEL_USER should always be passed, so the whole if-statement can be omitted in my opinion.
> Log implementation does not go through ops
> ------------------------------------------
>
> Key: AXIS2C-121
> URL: https://issues.apache.org/jira/browse/AXIS2C-121
> Project: Axis2-C
> Issue Type: Improvement
> Components: util
> Environment: Linux/Windows
> Reporter: Nabeel Yoosuf
> Assignee: Samisa Abeysinghe
> Priority: Minor
> Fix For: 1.0.0
>
>
> The log implemenation does not go through ops; as a result of that a user cannot plug his/her log implementation to use the engine. It would be better if we can have it aleast for Linux since there's a known problem with accessing fucntions with variable no of arguments through macros in windows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Commented: (AXIS2C-121) Log implementation does not go
through ops
Posted by "Pim Philipse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639769#action_12639769 ]
Pim Philipse commented on AXIS2C-121:
-------------------------------------
The function axutil_log_write() does go through ops, but the entire Axis2/c system relies for its logging on macro's like AXIS2_LOG_ERROR. And this particular one expands to axutil_log_impl_log_error, and that bypasses the ops and directly calls axutil_log_impl_write_to_file.
This causes confusion for my users, as they now have two log files they have to examine when something goes wrong.
Axis2/c supplies all the features for a user to alter the log implementation, then ignores the new implementation and uses the axutil_log_impl_* functions. This is the case in versions 1.1.0 and 1.5.0.
Please reopen the issue, remove the axutil_log_impl_log_* functions, change the macro's and let them point to functions that do go through ops, like
#define AXIS2_LOG_ERROR axutil_log_error
AXIS2_EXTERN void AXIS2_CALL
axutil_log_error(
axutil_log_t *log,
const axis2_char_t *filename,
const int linenumber,
const axis2_char_t *format,
...)
{
if (AXIS2_LOG_LEVEL_ERROR <= log->level)
{
char value[AXIS2_LEN_VALUE + 1];
va_list ap;
va_start(ap, format);
AXIS2_VSNPRINTF(value, AXIS2_LEN_VALUE, format, ap);
va_end(ap);
axutil_log_write(log, value, AXIS2_LOG_LEVEL_ERROR,
filename, linenumber);
}
}
> Log implementation does not go through ops
> ------------------------------------------
>
> Key: AXIS2C-121
> URL: https://issues.apache.org/jira/browse/AXIS2C-121
> Project: Axis2-C
> Issue Type: Improvement
> Components: util
> Environment: Linux/Windows
> Reporter: Nabeel Yoosuf
> Assignee: Samisa Abeysinghe
> Priority: Minor
> Fix For: 1.0.0
>
>
> The log implemenation does not go through ops; as a result of that a user cannot plug his/her log implementation to use the engine. It would be better if we can have it aleast for Linux since there's a known problem with accessing fucntions with variable no of arguments through macros in windows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Resolved: (AXIS2C-121) Log implementation does not go
through ops
Posted by "Samisa Abeysinghe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samisa Abeysinghe resolved AXIS2C-121.
--------------------------------------
Resolution: Fixed
Assignee: Samisa Abeysinghe (was: Dinesh Premalal)
It goes through ops. Ops is statically allocated
> Log implementation does not go through ops
> ------------------------------------------
>
> Key: AXIS2C-121
> URL: https://issues.apache.org/jira/browse/AXIS2C-121
> Project: Axis2-C
> Issue Type: Improvement
> Components: util
> Environment: Linux/Windows
> Reporter: Nabeel Yoosuf
> Assigned To: Samisa Abeysinghe
> Priority: Minor
> Fix For: 1.0.0
>
>
> The log implemenation does not go through ops; as a result of that a user cannot plug his/her log implementation to use the engine. It would be better if we can have it aleast for Linux since there's a known problem with accessing fucntions with variable no of arguments through macros in windows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Updated: (AXIS2C-121) Log implementation does not go through
ops
Posted by "Samisa Abeysinghe (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2C-121?page=all ]
Samisa Abeysinghe updated AXIS2C-121:
-------------------------------------
Fix Version/s: 0.96
> Log implementation does not go through ops
> ------------------------------------------
>
> Key: AXIS2C-121
> URL: http://issues.apache.org/jira/browse/AXIS2C-121
> Project: Axis2-C
> Issue Type: Improvement
> Components: util
> Environment: Linux/Windows
> Reporter: Nabeel Yoosuf
> Assigned To: Dinesh Premalal
> Priority: Minor
> Fix For: 0.96
>
>
> The log implemenation does not go through ops; as a result of that a user cannot plug his/her log implementation to use the engine. It would be better if we can have it aleast for Linux since there's a known problem with accessing fucntions with variable no of arguments through macros in windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org