You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Timothy Potter (JIRA)" <ji...@apache.org> on 2014/11/10 18:20:33 UTC
[jira] [Commented] (SOLR-6721)
ZkController.ensureReplicaInLeaderInitiatedRecovery puts replica in local
map before writing to ZK
[ https://issues.apache.org/jira/browse/SOLR-6721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205022#comment-14205022 ]
Timothy Potter commented on SOLR-6721:
--------------------------------------
My concern with this approach is that you can have literally 100's of failures going on at once and if you wait to add to the map until the write to ZK succeeds, it seems like there can be many attempted writes to ZK until the first one returns.
I think it would be better to add to the map first, so that any subsequent requests to put that replica into LIR know it's in-progress and then remove from the map if the write to ZK (updateLeaderInitiatedRecoveryState) fails.
> ZkController.ensureReplicaInLeaderInitiatedRecovery puts replica in local map before writing to ZK
> --------------------------------------------------------------------------------------------------
>
> Key: SOLR-6721
> URL: https://issues.apache.org/jira/browse/SOLR-6721
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 4.10.2
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6721.patch
>
>
> ZkController.ensureReplicaInLeaderInitiatedRecovery puts replica information in the local "replicasInLeaderInitiatedRecovery" map before writing to ZK. If there is an exception writing to ZK then the replica is still in the local map preventing future indexing failures from setting the replica in "down" state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org