You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/05/30 12:36:28 UTC
[GitHub] [bookkeeper] Shoothzj opened a new pull request, #3300: [build] fix broken master code compile error strerror_s
Shoothzj opened a new pull request, #3300:
URL: https://github.com/apache/bookkeeper/pull/3300
### Motivation
master compile is broken by #2549
### Changes
Add windows `#ifdef _WIN32` directive on `define`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj merged pull request #3300: [build] [windows] fix broken master code compile error strerror_s
Posted by GitBox <gi...@apache.org>.
Shoothzj merged PR #3300:
URL: https://github.com/apache/bookkeeper/pull/3300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3300: [build] [windows] fix broken master code compile error strerror_s
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #3300:
URL: https://github.com/apache/bookkeeper/pull/3300#issuecomment-1141164477
@Shoothzj master is broken only on Windows? what about adding a Github action to check win build compatibility ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3300: [build] [windows] fix broken master code compile error strerror_s
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3300:
URL: https://github.com/apache/bookkeeper/pull/3300#issuecomment-1141175644
@nicoloboschi I will add windows check once the windows support work done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3300: [build] [windows] fix broken master code compile error strerror_s
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3300:
URL: https://github.com/apache/bookkeeper/pull/3300#issuecomment-1141543609
`OWASP Dependency Check` failure: both `google-http-client-gson` and `maven-settings` are not related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3300: [build] [windows] fix broken master code compile error strerror_s
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3300:
URL: https://github.com/apache/bookkeeper/pull/3300#issuecomment-1141110161
@nicoloboschi @dlg99 @eolivelli @merlimat PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3300: [build] [windows] fix broken master code compile error strerror_s
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3300:
URL: https://github.com/apache/bookkeeper/pull/3300#issuecomment-1141166008
@nicoloboschi we haven't full support for windows yet(left one module). broken on my m1 mac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org