You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by joezou <jo...@apache.org> on 2020/09/28 16:13:04 UTC
[VOTE]: Move dubbo-go samples out of dubbo-samples
Hello Dubbo/Dubbogo Community,
This is a call for a vote to move dubbo-go samples[1] out of
dubbo-samples[2] , migrate to a new project which is called
dubbo-go-samples.
Now dubbo-samples include java and golang samples.For samples is great ,but
it is not good for managing integration testing for both versions.
Besides we want to add integration testing based on dubbo-go-samples from
now on ,but dubbo-samples[2] of java took a long time for integration
testing each time, close to 30 minutes [3]. Now more than 20 golang
samples, if take 1 minute for a sample, expect more than 20 minutes.
So we want to be independent of dubbo-samples.
[1]:https://github.com/apache/dubbo-samples/tree/master/golang
[2]:https://github.com/apache/dubbo-samples
[3]:https://travis-ci.org/github/apache/dubbo-samples/builds/730989552
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thanks,
The Apache Dubbo Team
Re: [VOTE]: Move dubbo-go samples out of dubbo-samples
Posted by wongoo <wo...@apache.org>.
+1 approve
On Tue, Sep 29, 2020 at 12:13 AM joezou <jo...@apache.org> wrote:
> Hello Dubbo/Dubbogo Community,
>
> This is a call for a vote to move dubbo-go samples[1] out of
> dubbo-samples[2] , migrate to a new project which is called
> dubbo-go-samples.
>
> Now dubbo-samples include java and golang samples.For samples is great ,but
> it is not good for managing integration testing for both versions.
>
> Besides we want to add integration testing based on dubbo-go-samples from
> now on ,but dubbo-samples[2] of java took a long time for integration
> testing each time, close to 30 minutes [3]. Now more than 20 golang
> samples, if take 1 minute for a sample, expect more than 20 minutes.
>
> So we want to be independent of dubbo-samples.
>
>
> [1]:https://github.com/apache/dubbo-samples/tree/master/golang
> [2]:https://github.com/apache/dubbo-samples
> [3]:https://travis-ci.org/github/apache/dubbo-samples/builds/730989552
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>
--
Regards,
Wongoo
Re: [VOTE]: Move dubbo-go samples out of dubbo-samples
Posted by 方银城 <fa...@gmail.com>.
+1 approve
stocks alex <al...@apache.org> 于2020年10月8日周四 下午5:36写道：
> I approve this suggestion now. because there is version branch in dubbo-go
> samples.
>
> YiXian Zou <yi...@gmail.com> 于2020年10月7日周三 上午10:43写道：
>
> > Hi,
> > So sorry for late reply. because there is something wrong with my
> VPN,
> > In my option, i am not suggest put samples or integration testing
> into
> > dubbo-go[1].
> >
> > The reason is
> > 1.As my first email, will take a long time for each PR or CI job .
> > 2.Make dubbo-go more and more complicated, at least in package
> > structure and package size. Then users download it will more and more
> > slower.
> >
> > My suggestion is
> > 1.Base on the Single Responsibility Principle , i hope to make
> > dubbo-go simple ,same as before, provide UT and require doc.
> > 2.Add a daily cron job for dubbo-go-sample , it will pull newest
> commit
> > from develop / master then run integration testing.
> >
> > [1]:https://github.com/apache/dubbo-go
> >
> > stocks alex <al...@apache.org> 于2020年10月1日周四 上午11:23写道：
> >
> > > To YunKun Huang,
> > > It's a good idea which I can not agree with u more.
> > >
> > > Mr Zou, I think we need to bound dubbo-go with its samples to keep
> > the
> > > version of dubbo-go-samples is the same with dubbo-go.
> > >
> > > YunKun Huang <ht...@gmail.com> 于2020年9月30日周三 下午7:43写道：
> > >
> > > > I think it's ok to move it out.
> > > > But I would like to know if its possible to include samples in
> dubbo-go
> > > > instead of dubbo-go-samples？
> > > >
> > > >
> > > > its more easy to maintain samples with dubbo-go together and manage
> > with
> > > > versioning
> > > >
> > > > On Wed, Sep 30, 2020 at 6:20 PM Ian Luo <ia...@gmail.com> wrote:
> > > >
> > > > > +1 to approve.
> > > > >
> > > > > On Tue, Sep 29, 2020 at 12:13 AM joezou <jo...@apache.org> wrote:
> > > > >
> > > > > > Hello Dubbo/Dubbogo Community,
> > > > > >
> > > > > > This is a call for a vote to move dubbo-go samples[1] out of
> > > > > > dubbo-samples[2] , migrate to a new project which is called
> > > > > > dubbo-go-samples.
> > > > > >
> > > > > > Now dubbo-samples include java and golang samples.For samples is
> > > great
> > > > > ,but
> > > > > > it is not good for managing integration testing for both
> versions.
> > > > > >
> > > > > > Besides we want to add integration testing based on
> > dubbo-go-samples
> > > > from
> > > > > > now on ,but dubbo-samples[2] of java took a long time for
> > integration
> > > > > > testing each time, close to 30 minutes [3]. Now more than 20
> golang
> > > > > > samples, if take 1 minute for a sample, expect more than 20
> > minutes.
> > > > > >
> > > > > > So we want to be independent of dubbo-samples.
> > > > > >
> > > > > >
> > > > > > [1]:https://github.com/apache/dubbo-samples/tree/master/golang
> > > > > > [2]:https://github.com/apache/dubbo-samples
> > > > > > [3]:
> > > https://travis-ci.org/github/apache/dubbo-samples/builds/730989552
> > > > > >
> > > > > > Please vote accordingly:
> > > > > >
> > > > > > [ ] +1 approve
> > > > > > [ ] +0 no opinion
> > > > > > [ ] -1 disapprove with the reason
> > > > > >
> > > > > > Thanks,
> > > > > > The Apache Dubbo Team
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE]: Move dubbo-go samples out of dubbo-samples
Posted by stocks alex <al...@apache.org>.
I approve this suggestion now. because there is version branch in dubbo-go
samples.
YiXian Zou <yi...@gmail.com> 于2020年10月7日周三 上午10:43写道：
> Hi,
> So sorry for late reply. because there is something wrong with my VPN,
> In my option, i am not suggest put samples or integration testing into
> dubbo-go[1].
>
> The reason is
> 1.As my first email, will take a long time for each PR or CI job .
> 2.Make dubbo-go more and more complicated, at least in package
> structure and package size. Then users download it will more and more
> slower.
>
> My suggestion is
> 1.Base on the Single Responsibility Principle , i hope to make
> dubbo-go simple ,same as before, provide UT and require doc.
> 2.Add a daily cron job for dubbo-go-sample , it will pull newest commit
> from develop / master then run integration testing.
>
> [1]:https://github.com/apache/dubbo-go
>
> stocks alex <al...@apache.org> 于2020年10月1日周四 上午11:23写道：
>
> > To YunKun Huang,
> > It's a good idea which I can not agree with u more.
> >
> > Mr Zou, I think we need to bound dubbo-go with its samples to keep
> the
> > version of dubbo-go-samples is the same with dubbo-go.
> >
> > YunKun Huang <ht...@gmail.com> 于2020年9月30日周三 下午7:43写道：
> >
> > > I think it's ok to move it out.
> > > But I would like to know if its possible to include samples in dubbo-go
> > > instead of dubbo-go-samples？
> > >
> > >
> > > its more easy to maintain samples with dubbo-go together and manage
> with
> > > versioning
> > >
> > > On Wed, Sep 30, 2020 at 6:20 PM Ian Luo <ia...@gmail.com> wrote:
> > >
> > > > +1 to approve.
> > > >
> > > > On Tue, Sep 29, 2020 at 12:13 AM joezou <jo...@apache.org> wrote:
> > > >
> > > > > Hello Dubbo/Dubbogo Community,
> > > > >
> > > > > This is a call for a vote to move dubbo-go samples[1] out of
> > > > > dubbo-samples[2] , migrate to a new project which is called
> > > > > dubbo-go-samples.
> > > > >
> > > > > Now dubbo-samples include java and golang samples.For samples is
> > great
> > > > ,but
> > > > > it is not good for managing integration testing for both versions.
> > > > >
> > > > > Besides we want to add integration testing based on
> dubbo-go-samples
> > > from
> > > > > now on ,but dubbo-samples[2] of java took a long time for
> integration
> > > > > testing each time, close to 30 minutes [3]. Now more than 20 golang
> > > > > samples, if take 1 minute for a sample, expect more than 20
> minutes.
> > > > >
> > > > > So we want to be independent of dubbo-samples.
> > > > >
> > > > >
> > > > > [1]:https://github.com/apache/dubbo-samples/tree/master/golang
> > > > > [2]:https://github.com/apache/dubbo-samples
> > > > > [3]:
> > https://travis-ci.org/github/apache/dubbo-samples/builds/730989552
> > > > >
> > > > > Please vote accordingly:
> > > > >
> > > > > [ ] +1 approve
> > > > > [ ] +0 no opinion
> > > > > [ ] -1 disapprove with the reason
> > > > >
> > > > > Thanks,
> > > > > The Apache Dubbo Team
> > > > >
> > > >
> > >
> >
>
Re: [VOTE]: Move dubbo-go samples out of dubbo-samples
Posted by YiXian Zou <yi...@gmail.com>.
Hi,
So sorry for late reply. because there is something wrong with my VPN,
In my option, i am not suggest put samples or integration testing into
dubbo-go[1].
The reason is
1.As my first email, will take a long time for each PR or CI job .
2.Make dubbo-go more and more complicated, at least in package
structure and package size. Then users download it will more and more
slower.
My suggestion is
1.Base on the Single Responsibility Principle , i hope to make
dubbo-go simple ,same as before, provide UT and require doc.
2.Add a daily cron job for dubbo-go-sample , it will pull newest commit
from develop / master then run integration testing.
[1]:https://github.com/apache/dubbo-go
stocks alex <al...@apache.org> 于2020年10月1日周四 上午11:23写道：
> To YunKun Huang,
> It's a good idea which I can not agree with u more.
>
> Mr Zou, I think we need to bound dubbo-go with its samples to keep the
> version of dubbo-go-samples is the same with dubbo-go.
>
> YunKun Huang <ht...@gmail.com> 于2020年9月30日周三 下午7:43写道：
>
> > I think it's ok to move it out.
> > But I would like to know if its possible to include samples in dubbo-go
> > instead of dubbo-go-samples？
> >
> >
> > its more easy to maintain samples with dubbo-go together and manage with
> > versioning
> >
> > On Wed, Sep 30, 2020 at 6:20 PM Ian Luo <ia...@gmail.com> wrote:
> >
> > > +1 to approve.
> > >
> > > On Tue, Sep 29, 2020 at 12:13 AM joezou <jo...@apache.org> wrote:
> > >
> > > > Hello Dubbo/Dubbogo Community,
> > > >
> > > > This is a call for a vote to move dubbo-go samples[1] out of
> > > > dubbo-samples[2] , migrate to a new project which is called
> > > > dubbo-go-samples.
> > > >
> > > > Now dubbo-samples include java and golang samples.For samples is
> great
> > > ,but
> > > > it is not good for managing integration testing for both versions.
> > > >
> > > > Besides we want to add integration testing based on dubbo-go-samples
> > from
> > > > now on ,but dubbo-samples[2] of java took a long time for integration
> > > > testing each time, close to 30 minutes [3]. Now more than 20 golang
> > > > samples, if take 1 minute for a sample, expect more than 20 minutes.
> > > >
> > > > So we want to be independent of dubbo-samples.
> > > >
> > > >
> > > > [1]:https://github.com/apache/dubbo-samples/tree/master/golang
> > > > [2]:https://github.com/apache/dubbo-samples
> > > > [3]:
> https://travis-ci.org/github/apache/dubbo-samples/builds/730989552
> > > >
> > > > Please vote accordingly:
> > > >
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> > > > Thanks,
> > > > The Apache Dubbo Team
> > > >
> > >
> >
>
Re: [VOTE]: Move dubbo-go samples out of dubbo-samples
Posted by stocks alex <al...@apache.org>.
To YunKun Huang,
It's a good idea which I can not agree with u more.
Mr Zou, I think we need to bound dubbo-go with its samples to keep the
version of dubbo-go-samples is the same with dubbo-go.
YunKun Huang <ht...@gmail.com> 于2020年9月30日周三 下午7:43写道：
> I think it's ok to move it out.
> But I would like to know if its possible to include samples in dubbo-go
> instead of dubbo-go-samples？
>
>
> its more easy to maintain samples with dubbo-go together and manage with
> versioning
>
> On Wed, Sep 30, 2020 at 6:20 PM Ian Luo <ia...@gmail.com> wrote:
>
> > +1 to approve.
> >
> > On Tue, Sep 29, 2020 at 12:13 AM joezou <jo...@apache.org> wrote:
> >
> > > Hello Dubbo/Dubbogo Community,
> > >
> > > This is a call for a vote to move dubbo-go samples[1] out of
> > > dubbo-samples[2] , migrate to a new project which is called
> > > dubbo-go-samples.
> > >
> > > Now dubbo-samples include java and golang samples.For samples is great
> > ,but
> > > it is not good for managing integration testing for both versions.
> > >
> > > Besides we want to add integration testing based on dubbo-go-samples
> from
> > > now on ,but dubbo-samples[2] of java took a long time for integration
> > > testing each time, close to 30 minutes [3]. Now more than 20 golang
> > > samples, if take 1 minute for a sample, expect more than 20 minutes.
> > >
> > > So we want to be independent of dubbo-samples.
> > >
> > >
> > > [1]:https://github.com/apache/dubbo-samples/tree/master/golang
> > > [2]:https://github.com/apache/dubbo-samples
> > > [3]:https://travis-ci.org/github/apache/dubbo-samples/builds/730989552
> > >
> > > Please vote accordingly:
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Thanks,
> > > The Apache Dubbo Team
> > >
> >
>
Re: [VOTE]: Move dubbo-go samples out of dubbo-samples
Posted by YunKun Huang <ht...@gmail.com>.
I think it's ok to move it out.
But I would like to know if its possible to include samples in dubbo-go
instead of dubbo-go-samples？
its more easy to maintain samples with dubbo-go together and manage with
versioning
On Wed, Sep 30, 2020 at 6:20 PM Ian Luo <ia...@gmail.com> wrote:
> +1 to approve.
>
> On Tue, Sep 29, 2020 at 12:13 AM joezou <jo...@apache.org> wrote:
>
> > Hello Dubbo/Dubbogo Community,
> >
> > This is a call for a vote to move dubbo-go samples[1] out of
> > dubbo-samples[2] , migrate to a new project which is called
> > dubbo-go-samples.
> >
> > Now dubbo-samples include java and golang samples.For samples is great
> ,but
> > it is not good for managing integration testing for both versions.
> >
> > Besides we want to add integration testing based on dubbo-go-samples from
> > now on ,but dubbo-samples[2] of java took a long time for integration
> > testing each time, close to 30 minutes [3]. Now more than 20 golang
> > samples, if take 1 minute for a sample, expect more than 20 minutes.
> >
> > So we want to be independent of dubbo-samples.
> >
> >
> > [1]:https://github.com/apache/dubbo-samples/tree/master/golang
> > [2]:https://github.com/apache/dubbo-samples
> > [3]:https://travis-ci.org/github/apache/dubbo-samples/builds/730989552
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo Team
> >
>
Re: [VOTE]: Move dubbo-go samples out of dubbo-samples
Posted by Ian Luo <ia...@gmail.com>.
+1 to approve.
On Tue, Sep 29, 2020 at 12:13 AM joezou <jo...@apache.org> wrote:
> Hello Dubbo/Dubbogo Community,
>
> This is a call for a vote to move dubbo-go samples[1] out of
> dubbo-samples[2] , migrate to a new project which is called
> dubbo-go-samples.
>
> Now dubbo-samples include java and golang samples.For samples is great ,but
> it is not good for managing integration testing for both versions.
>
> Besides we want to add integration testing based on dubbo-go-samples from
> now on ,but dubbo-samples[2] of java took a long time for integration
> testing each time, close to 30 minutes [3]. Now more than 20 golang
> samples, if take 1 minute for a sample, expect more than 20 minutes.
>
> So we want to be independent of dubbo-samples.
>
>
> [1]:https://github.com/apache/dubbo-samples/tree/master/golang
> [2]:https://github.com/apache/dubbo-samples
> [3]:https://travis-ci.org/github/apache/dubbo-samples/builds/730989552
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>