You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2014/08/12 14:39:57 UTC
[4/5] git commit: Cache the got value and reuse it in a method
Cache the got value and reuse it in a method
(cherry picked from commit ca6e424c89d3b75216e58bf0733637aeb37c4a8c)
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/3d9a4a6f
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/3d9a4a6f
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/3d9a4a6f
Branch: refs/heads/master
Commit: 3d9a4a6f5968b84338cc46f9255f9f02b30ca0dc
Parents: 24c8eb1
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Tue Aug 12 14:10:06 2014 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Tue Aug 12 14:39:32 2014 +0200
----------------------------------------------------------------------
.../wicket/atmosphere/AtmosphereRequestHandler.java | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/3d9a4a6f/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereRequestHandler.java
----------------------------------------------------------------------
diff --git a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereRequestHandler.java b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereRequestHandler.java
index 48bd5e2e..8824468 100644
--- a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereRequestHandler.java
+++ b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereRequestHandler.java
@@ -70,8 +70,9 @@ public class AtmosphereRequestHandler implements IRequestHandler
@Override
public void respond(IRequestCycle requestCycle)
{
- Page page = (Page)Application.get().getMapperContext().getPageInstance(pageKey.getPageId());
- AjaxRequestTarget target = WebApplication.get().newAjaxRequestTarget(page);
+ WebApplication application = WebApplication.get();
+ Page page = (Page)application.getMapperContext().getPageInstance(pageKey.getPageId());
+ AjaxRequestTarget target = application.newAjaxRequestTarget(page);
executeHandlers(target, page);
}
@@ -85,14 +86,15 @@ public class AtmosphereRequestHandler implements IRequestHandler
Component component = page.get(componentPath);
if (component != null)
{
- if (curSubscription.getBehaviorIndex() == null)
+ Integer behaviorIndex = curSubscription.getBehaviorIndex();
+ if (behaviorIndex == null)
{
invokeMethod(target, curSubscription, component);
}
else
{
- invokeMethod(target, curSubscription,
- component.getBehaviorById(curSubscription.getBehaviorIndex()));
+ Behavior behavior = component.getBehaviorById(behaviorIndex);
+ invokeMethod(target, curSubscription, behavior);
}
}
else