You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/22 04:49:37 UTC
[GitHub] [hbase-thirdparty] saintstack opened a new pull request #10:
HBASE-23718 [hbase-thirdparty] Update libs; pb from 3.9 to 3.11, etc.
saintstack opened a new pull request #10: HBASE-23718 [hbase-thirdparty] Update libs; pb from 3.9 to 3.11, etc.
URL: https://github.com/apache/hbase-thirdparty/pull/10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-thirdparty] petersomogyi commented on a change in pull
request #10: HBASE-23718 [hbase-thirdparty] Update libs;
pb from 3.9 to 3.11, etc.
Posted by GitBox <gi...@apache.org>.
petersomogyi commented on a change in pull request #10: HBASE-23718 [hbase-thirdparty] Update libs; pb from 3.9 to 3.11, etc.
URL: https://github.com/apache/hbase-thirdparty/pull/10#discussion_r369729526
##########
File path: pom.xml
##########
@@ -127,7 +127,7 @@
<java.min.version>${compileSource}</java.min.version>
<maven.min.version>3.3.3</maven.min.version>
<rename.offset>org.apache.hbase.thirdparty</rename.offset>
- <protobuf.version>3.9.2</protobuf.version>
+ <protobuf.version>3.11.1</protobuf.version>
Review comment:
Any reason not going to 3.11.2 directly?
https://github.com/protocolbuffers/protobuf/releases/tag/v3.11.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-thirdparty] saintstack commented on a change in pull request
#10: HBASE-23718 [hbase-thirdparty] Update libs; pb from 3.9 to 3.11, etc.
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #10: HBASE-23718 [hbase-thirdparty] Update libs; pb from 3.9 to 3.11, etc.
URL: https://github.com/apache/hbase-thirdparty/pull/10#discussion_r369803580
##########
File path: pom.xml
##########
@@ -127,7 +127,7 @@
<java.min.version>${compileSource}</java.min.version>
<maven.min.version>3.3.3</maven.min.version>
<rename.offset>org.apache.hbase.thirdparty</rename.offset>
- <protobuf.version>3.9.2</protobuf.version>
+ <protobuf.version>3.11.1</protobuf.version>
Review comment:
It was not up in the mvn repos when I was at this last night https://mvnrepository.com/artifact/com.google.protobuf/protobuf-java ... and no java commits in 3.11.2 anyways: https://github.com/protocolbuffers/protobuf/compare/v3.11.2...3.11.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-thirdparty] saintstack merged pull request #10: HBASE-23718
[hbase-thirdparty] Update libs; pb from 3.9 to 3.11, etc.
Posted by GitBox <gi...@apache.org>.
saintstack merged pull request #10: HBASE-23718 [hbase-thirdparty] Update libs; pb from 3.9 to 3.11, etc.
URL: https://github.com/apache/hbase-thirdparty/pull/10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services