You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/07/22 08:59:49 UTC
Review Request 36684: Fixed a bug related to persistent volumes
during slave recovery.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36684/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Bugs: MESOS-3124
https://issues.apache.org/jira/browse/MESOS-3124
Repository: mesos
Description
-------
Fixed a bug related to persistent volumes during slave recovery.
Diffs
-----
src/slave/containerizer/isolators/filesystem/posix.cpp 1904279c92ef00ef931c909b4bb15bef89a4fc59
Diff: https://reviews.apache.org/r/36684/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 36684: Fixed a bug related to persistent volumes
during slave recovery.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36684/#review92560
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36683, 36684]
All tests passed.
- Mesos ReviewBot
On July 22, 2015, 6:59 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36684/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 6:59 a.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-3124
> https://issues.apache.org/jira/browse/MESOS-3124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a bug related to persistent volumes during slave recovery.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/filesystem/posix.cpp 1904279c92ef00ef931c909b4bb15bef89a4fc59
>
> Diff: https://reviews.apache.org/r/36684/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 36684: Fixed a bug related to persistent volumes
during slave recovery.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36684/#review92648
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36683, 36684]
All tests passed.
- Mesos ReviewBot
On July 22, 2015, 8:09 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36684/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 8:09 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-3124
> https://issues.apache.org/jira/browse/MESOS-3124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a bug related to persistent volumes during slave recovery.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/filesystem/posix.cpp 1904279c92ef00ef931c909b4bb15bef89a4fc59
>
> Diff: https://reviews.apache.org/r/36684/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 36684: Fixed a bug related to persistent volumes
during slave recovery.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36684/#review92664
-----------------------------------------------------------
Ship it!
src/slave/containerizer/isolators/filesystem/posix.cpp (line 233)
<https://reviews.apache.org/r/36684/#comment146888>
s/expect it/expect/
- Vinod Kone
On July 22, 2015, 10:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36684/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 10:55 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-3124
> https://issues.apache.org/jira/browse/MESOS-3124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a bug related to persistent volumes during slave recovery.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/filesystem/posix.cpp 1904279c92ef00ef931c909b4bb15bef89a4fc59
>
> Diff: https://reviews.apache.org/r/36684/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 36684: Fixed a bug related to persistent volumes
during slave recovery.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36684/
-----------------------------------------------------------
(Updated July 22, 2015, 10:55 p.m.)
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Bugs: MESOS-3124
https://issues.apache.org/jira/browse/MESOS-3124
Repository: mesos
Description
-------
Fixed a bug related to persistent volumes during slave recovery.
Diffs
-----
src/slave/containerizer/isolators/filesystem/posix.cpp 1904279c92ef00ef931c909b4bb15bef89a4fc59
Diff: https://reviews.apache.org/r/36684/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 36684: Fixed a bug related to persistent volumes
during slave recovery.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36684/
-----------------------------------------------------------
(Updated July 22, 2015, 8:09 p.m.)
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Changes
-------
Addressed review comments.
Bugs: MESOS-3124
https://issues.apache.org/jira/browse/MESOS-3124
Repository: mesos
Description
-------
Fixed a bug related to persistent volumes during slave recovery.
Diffs (updated)
-----
src/slave/containerizer/isolators/filesystem/posix.cpp 1904279c92ef00ef931c909b4bb15bef89a4fc59
Diff: https://reviews.apache.org/r/36684/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 36684: Fixed a bug related to persistent volumes
during slave recovery.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36684/#review92622
-----------------------------------------------------------
Ship it!
src/slave/containerizer/isolators/filesystem/posix.cpp (lines 222 - 223)
<https://reviews.apache.org/r/36684/#comment146831>
I think this merits more explanation on when exactly we might end up in this situation.
- Vinod Kone
On July 22, 2015, 6:59 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36684/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 6:59 a.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-3124
> https://issues.apache.org/jira/browse/MESOS-3124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a bug related to persistent volumes during slave recovery.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/filesystem/posix.cpp 1904279c92ef00ef931c909b4bb15bef89a4fc59
>
> Diff: https://reviews.apache.org/r/36684/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>