You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/10 13:20:14 UTC
[GitHub] [arrow] MironAtHome opened a new issue #12114: Build just doesn't work on windows. Any chance to put together decent .vcproj files?
MironAtHome opened a new issue #12114:
URL: https://github.com/apache/arrow/issues/12114
Hey guys, would you accept a few decent .vcproj files to build on windows?
What you have with all these cmake and vcpkg is
a. overly complicated
b. doesn't work
and the worst of it, with .vcproj it's sorta easy to figure out what needs to be tweaked, like external library support ( it wouldn't hurt to list those out ) and replaceable #11782
Can we agree to some conditions of peace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome edited a comment on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome edited a comment on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1009262209
It is my understanding that much effort is to maintain single set of scripts and use parameters to drive features / files selected for compiler to build product.
I will try to emulate it closely.
For the moment I already have vcproj project file for Visual Studio 2017 ( I believe it will work with editions 2019 and 2022 as well ). Need to
a. document dependencies
b. wire in parameters driving similar to cmake feature / file filtering
c. take a step back and consider placeholders, replaced by cmake
d. ensure and run unit tests
--- optionally / next on the list
e. add c# wrappers to some of the code using c++ CLR to provide for seamless integration with .NET
----
The advantage of having vcproj files is that anyone with Visual Studio will be able to load those, clone dependencies ( unless I missed those are submodules that just need a sync up? ) and run build. And if something fails it would be fairly transparent how and what needs to be fixed. Learning new tools, such as CMake is probably great, but it does take time. So, having vcproj is really nice to get up and running quickly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome edited a comment on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome edited a comment on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1009265400
```
My understanding is that some effort done to maintain single set of scripts and use parameters to drive features / files selected for compiler to build product.
I will try to emulate it closely.
For the moment I already have vcproj project file for Visual Studio 2017 ( I believe it will work with editions 2019 and 2022 as well ) that builds parquet library. Need to
a. document dependencies or confirm those are submodules
b. wire in parameters driving similar to cmake feature / file filtering
c. take a step back and consider placeholders, replaced by cmake
d. ensure and run unit tests
--- optionally / next on the list
e. add c# wrappers to some of the code using c++ CLR to provide for seamless integration with .NET
f. replace getenv with updated / secure version getenv_s for test feature
----
The advantage of having vcproj files is that anyone with Visual Studio will be able to load those, clone dependencies ( unless I missed those are submodules that just need a sync up? ) and run build. And if something fails it would be fairly transparent how and what needs to be fixed. Learning new tools, such as CMake is probably great, but it does take time. So, having vcproj is really nice to get up and running quickly.**
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome edited a comment on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome edited a comment on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1009265400
```
My understanding that some effort is to maintain single set of scripts and use parameters to drive features / files selected for compiler to build product.
I will try to emulate it closely.
For the moment I already have vcproj project file for Visual Studio 2017 ( I believe it will work with editions 2019 and 2022 as well ). Need to
a. document dependencies
b. wire in parameters driving similar to cmake feature / file filtering
c. take a step back and consider placeholders, replaced by cmake
d. ensure and run unit tests
--- optionally / next on the list
e. add c# wrappers to some of the code using c++ CLR to provide for seamless integration with .NET
----
The advantage of having vcproj files is that anyone with Visual Studio will be able to load those, clone dependencies ( unless I missed those are submodules that just need a sync up? ) and run build. And if something fails it would be fairly transparent how and what needs to be fixed. Learning new tools, such as CMake is probably great, but it does take time. So, having vcproj is really nice to get up and running quickly.**
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome edited a comment on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome edited a comment on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1009265400
```
My understanding is that some effort done to maintain single set of scripts and
use parameters to drive features / files selected for compiler to build
product.
I will try to emulate it closely.
For the moment I already have vcproj project file for Visual Studio 2017 ( I believe it will work with editions 2019 and 2022 as well ) that builds parquet library. Need to
a. document dependencies or confirm those are submodules
b. wire in parameters driving similar to cmake feature / file filtering
c. take a step back and consider placeholders, replaced by cmake
d. ensure and run unit tests
--- optionally / next on the list
e. add c# wrappers to some of the code using c++ CLR to provide for seamless integration with .NET
f. replace getenv with updated / secure version getenv_s for test feature
----
The advantage of having vcproj files is that anyone with Visual Studio will be able to
load those, clone dependencies ( unless I missed those are submodules that just need
a sync up? ) and run build. And if something fails it would be fairly transparent how
and what needs to be fixed. Learning new tools, such as CMake is probably great, but
it does take time. So, having vcproj is really nice to get up and running quickly.
**
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome commented on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome commented on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1009262209
It is my understanding that much effort is to maintain single set of scripts and use parameters to drive features / files selected for compiler to build product.
I will try to emulate it closely.
For the moment I already have vcproj project file for Visual Studio 2017 ( I believe it will work with editions 2019 and 2022 as well ). Need to
a. document dependencies
b. wire in parameters driving similar to cmake feature / file filtering
c. take a step back and consider placeholders, replaced by cmake
d. ensure and run unit tests
--- optionally / next on the list
e. add c# wrappers to some of the code using c++ CLR to provide for seamless integration with .NET
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome removed a comment on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome removed a comment on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1009262209
**It is my understanding that much effort is to maintain single set of scripts and use parameters to drive features / files selected for compiler to build product.
I will try to emulate it closely.
For the moment I already have vcproj project file for Visual Studio 2017 ( I believe it will work with editions 2019 and 2022 as well ). Need to
a. document dependencies
b. wire in parameters driving similar to cmake feature / file filtering
c. take a step back and consider placeholders, replaced by cmake
d. ensure and run unit tests
--- optionally / next on the list
e. add c# wrappers to some of the code using c++ CLR to provide for seamless integration with .NET
----
The advantage of having vcproj files is that anyone with Visual Studio will be able to load those, clone dependencies ( unless I missed those are submodules that just need a sync up? ) and run build. And if something fails it would be fairly transparent how and what needs to be fixed. Learning new tools, such as CMake is probably great, but it does take time. So, having vcproj is really nice to get up and running quickly.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
thisisnic commented on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1009008566
Hi @MironAtHome - I'm not sure what you mean by "conditions of peace", but that's fantastic that you're thinking of submitting a pull request.
When you say "just doesn't work", would you mind providing a little more context in terms of what you've tried and in what way it didn't work?
Alternatively, we always welcome new contributions, so that's fine to just submit the PR and we can discuss your improvements there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome edited a comment on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome edited a comment on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1009265400
```
My understanding is that some effort done to maintain single set of scripts and use parameters to drive features / files selected for compiler to build product.
I will try to emulate it closely.
For the moment I already have vcproj project file for Visual Studio 2017 ( I believe it will work with editions 2019 and 2022 as well ) that builds parquet library. Need to
a. document dependencies or confirm those are submodules
b. wire in parameters driving similar to cmake feature / file filtering
c. take a step back and consider placeholders, replaced by cmake
d. ensure and run unit tests
--- optionally / next on the list
e. add c# wrappers to some of the code using c++ CLR to provide for seamless integration with .NET
f. replace getenv with updated / secure version getenv_s for test feature
----
The advantage of having vcproj files is that anyone with Visual Studio will be able to
load those, clone dependencies ( unless I missed those are submodules that just need
a sync up? ) and run build. And if something fails it would be fairly transparent how
and what needs to be fixed. Learning new tools, such as CMake is probably great, but
it does take time. So, having vcproj is really nice to get up and running quickly.
**
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome commented on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome commented on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1009259206
Here is repro.
Install Microsoft Visual Studio 2017 with C/C++ compiler ( version 141 )
Make sure to install all features related to cmake build tools
Install vspkg, run initialization script, as per requirements
Perform steps described in the build guide document: arrow/docs/source/developers/cpp/building.rst
---------
Expected result: product builds without issues.
--------
Actual result: messages with error description
- example -
-- Selecting Windows SDK version to target Windows 10.0.14393.
-- The C compiler identification is unknown
CMake Warning (dev) at CMakeFiles/3.12.18081601-MSVC_2/CMakeCCompiler.cmake:23:
Syntax Warning in cmake code at column 20
Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
CMakeLists.txt
This warning is for project developers. Use -Wno-dev to suppress it.
CMake Warning (dev) at CMakeFiles/3.12.18081601-MSVC_2/CMakeCCompiler.cmake:23:
Syntax Warning in cmake code at column 42
Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
CMakeLists.txt
This warning is for project developers. Use -Wno-dev to suppress it.
-- The CXX compiler identification is unknown
CMake Warning (dev) at CMakeFiles/3.12.18081601-MSVC_2/CMakeCXXCompiler.cmake:25:
Syntax Warning in cmake code at column 137
Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
CMakeLists.txt
This warning is for project developers. Use -Wno-dev to suppress it.
CMake Error in CMakeLists.txt:
No CMAKE_C_COMPILER could be found.
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Tools/MSVC/14.16.27023/bin/Hostx64/x64/cl.exe
CMake Warning (dev) at F:/HL/dev/git/arrow/cpp/src/parquet/CMakeFiles/3.12.18081601-MSVC_2/CMakeCXXCompiler.cmake:25:
Syntax Warning in cmake code at column 137
Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
F:/HL/dev/git/arrow/cpp/src/parquet/CMakeFiles/CMakeTmp/CMakeLists.txt:2 (project)
This warning is for project developers. Use -Wno-dev to suppress it.
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Tools/MSVC/14.16.27023/bin/Hostx64/x64/cl.exe -- broken
CMake Error at C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.12/Modules/CMakeTestCXXCompiler.cmake:45 (message):
The C++ compiler
"C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Tools/MSVC/14.16.27023/bin/Hostx64/x64/cl.exe"
is not able to compile a simple test program.
It fails with the following output:
Change Dir: F:/HL/dev/git/arrow/cpp/src/parquet/CMakeFiles/CMakeTmp
Run Build Command:"C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/MSBuild/15.0/Bin/MSBuild.exe" "cmTC_567b6.vcxproj" "/p:Configuration=Debug" "/p:VisualStudioVersion=15.0"
Microsoft (R) Build Engine version 15.9.21+g9802d43bc3 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.
Build started 10.01.2022 4:58:34.
Project "F:\HL\dev\git\arrow\cpp\src\parquet\CMakeFiles\CMakeTmp\cmTC_567b6.vcxproj" on node 1 (default targets).
PrepareForBuild:
Creating directory "cmTC_567b6.dir\Debug\".
Creating directory "F:\HL\dev\git\arrow\cpp\src\parquet\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_567b6.dir\Debug\cmTC_567b6.tlog\".
InitializeBuildStatus:
Creating "cmTC_567b6.dir\Debug\cmTC_567b6.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
VcpkgTripletSelection:
Using triplet "x86-windows" from "F:\HL\dev\git\vcpkg\installed\x86-windows\"
VcpkgCheckManifestRoot:
The vcpkg manifest was disabled, but we found a manifest file in F:\HL\dev\git\arrow\cpp\. You may want to enable vcpkg manifests in your properties page or pass /p:VcpkgEnableManifest=true to the msbuild invocation.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\HostX86\x86\CL.exe /c /I"F:\HL\dev\git\vcpkg\installed\x86-windows\include" /W1 /WX- /diagnostics:classic /O2 /Oy- /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /MD /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_567b6.dir\Debug\\" /Fd"cmTC_567b6.dir\Debug\vc141.pdb" /Gd /TP /analyze- /FC /errorReport:queue F:\HL\dev\git\arrow\cpp\src\parquet\CMakeFiles\CMakeTmp\testCXXCompiler.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27031.1 for x86
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /I"F:\HL\dev\git\vcpkg\installed\x86-windows\include" /W1 /WX- /diagnostics:classic /O2 /Oy- /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /MD /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_567b6.dir\Debug\\" /Fd"cmTC_567b6.dir\Debug\vc141.pdb" /Gd /TP /analyze- /FC /errorReport:queue F:\HL\dev\git\arrow\cpp\src\parquet\CMakeFiles\CMakeTmp\testCXXCompiler.cxx
testCXXCompiler.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\HostX86\x86\link.exe /ERRORREPORT:QUEUE /OUT:"F:\HL\dev\git\arrow\cpp\src\parquet\CMakeFiles\CMakeTmp\Debug\cmTC_567b6.exe" /INCREMENTAL /NOLOGO /LIBPATH:"F:\HL\dev\git\vcpkg\installed\x86-windows\debug\lib" /LIBPATH:"F:\HL\dev\git\vcpkg\installed\x86-windows\debug\lib\manual-link" "F:\HL\dev\git\vcpkg\installed\x86-windows\debug\lib\*.lib" /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /PDB:"F:/HL/dev/git/arrow/cpp/src/parquet/CMakeFiles/CMakeTmp/Debug/cmTC_567b6.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"F:/HL/dev/git/arrow/cpp/src/parquet/CMakeFiles/CMakeTmp/Debug/cmTC_567b6.lib" /MACHINE:X86 /SAFESEH cmTC_567b6.dir\Debug\testCXXCompiler.obj
LINK : fatal error LNK1104: cannot open file 'ucrt.lib' [F:\HL\dev\git\arrow\cpp\src\parquet\CMakeFiles\CMakeTmp\cmTC_567b6.vcxproj]
Done Building Project "F:\HL\dev\git\arrow\cpp\src\parquet\CMakeFiles\CMakeTmp\cmTC_567b6.vcxproj" (default targets) -- FAILED.
Build FAILED.
"F:\HL\dev\git\arrow\cpp\src\parquet\CMakeFiles\CMakeTmp\cmTC_567b6.vcxproj" (default target) (1) ->
(Link target) ->
LINK : fatal error LNK1104: cannot open file 'ucrt.lib' [F:\HL\dev\git\arrow\cpp\src\parquet\CMakeFiles\CMakeTmp\cmTC_567b6.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:01.45
CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
CMakeLists.txt
CMake Warning (dev) in CMakeLists.txt:
No cmake_minimum_required command is present. A line of code such as
cmake_minimum_required(VERSION 3.12)
should be added at the top of the file. The version specified may be lower
if you wish to support older CMake versions for this project. For more
information run "cmake --help-policy CMP0000".
This warning is for project developers. Use -Wno-dev to suppress it.
-- Configuring incomplete, errors occurred!
See also "F:/HL/dev/git/arrow/cpp/src/parquet/CMakeFiles/CMakeOutput.log".
See also "F:/HL/dev/git/arrow/cpp/src/parquet/CMakeFiles/CMakeError.log"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
thisisnic commented on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1011013064
Thanks for those logs - looks like you may have some configuration issues there. It looks like it’s failing on linking to ucrtd.lib - people seem to get similar error messages when the Windows SDK is not installed - just to check, do you have this installed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome edited a comment on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome edited a comment on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1015701889
Yes, I have installed those and built in two different machines, one my home laptop the other one is my work laptop.
On both I ended up installing Visual Studio 2019 and latest SDK.
Here is SDK I am referencing in my vcxproj file: 10.0.20348.0
I have built up two of vsxproj files for parquet and for arrow projects.
Here is the list:
arrow - done
gandiva
generated
jni
parquet - done
plasma
skyhook
the next is probably gandiva.
I have ran along the way into an unique_ptr template compilation failure and had to add a few lines, to ensure project compiles.
Also, with warnings as errors a few security missing functions came up, such as getenv and strerror.
Since my goal is to ensure project compiles, rather than mere edding project files, fixing those as those appear.
So, it makes me move a bit slower than I hoped, but two projects over one week is a progress. I will advance further as quickly as I can with PR.
I do feel that those project files have value to them, since complicated environment proposed in this way by means of "here is how you do it" can be an overhead. I am seeing other projects where vcxproj files are being added and it does look like a mainstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome commented on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome commented on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1015701889
Yes, I have installed those and built in two different machines, one my home laptop the other one is my work laptop.
On both I ended up installing Visual Studio 2019 and latest SDK.
Here is SDK I am referencing in my vcxproj file: 10.0.20348.0
I have built up two of vsxproj files for parquet and for arrow projects.
Here is the list:
arrow
gandiva
generated
jni
parquet
plasma
skyhook
the next is probably gandiva.
I have ran along the way into an unique_ptr template compilation failure and had to add a few lines, to ensure project compiles.
Also, with warnings as errors a few security missing functions came up, such as getenv and strerror.
Since my goal is to ensure project compiles, rather than mere edding project files, fixing those as those appear.
So, it makes me move a bit slower than I hoped, but two projects over one week is a progress. I will advance further as quickly as I can with PR.
I do feel that those project files have value to them, since complicated environment proposed in this way by means of "here is how you do it" can be an overhead. I am seeing other projects where vcxproj files are being added and it does look like a mainstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome edited a comment on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome edited a comment on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1015701889
Yes, I have installed those and built in two different machines, one my home laptop the other one is my work laptop.
On both I ended up installing Visual Studio 2019 and latest SDK.
Here is SDK I am referencing in my vcxproj file: 10.0.20348.0 on both machines.
I have built up two of vsxproj files for parquet and for arrow projects.
Here is the list:
arrow - done
gandiva
generated
jni
parquet - done
plasma
skyhook
the next is probably gandiva.
I have ran along the way into an unique_ptr template compilation failure related to compressed.h CompressedOutputStream / CompressedInputStream, the
std::unique_ptr<Impl> impl_;
ended up adding
struct ARROW_NO_EXPORT ImplDeleter {
void operator()(Impl*) const;
};
std::unique_ptr<Impl, ImplDeleter> impl_;
to compile successfully.
Also, with warnings as errors a few security missing functions came up, such as getenv and strerror. Since my goal is to ensure project compiles, rather than mere edding project files, fixing those as those appear.
So, it makes me move a bit slower than I hoped, but two projects over one week is a progress. I will advance further as quickly as I can with PR.
I do feel that those project files have value to them, since complicated environment proposed in this way by means of "here is how you do it" can be an overhead. I am seeing other projects where vcxproj files are being added and it does look like a mainstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome edited a comment on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome edited a comment on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1015701889
Yes, I have installed those and built in two different machines, one my home laptop the other one is my work laptop.
On both I ended up installing Visual Studio 2019 and latest SDK.
Here is SDK I am referencing in my vcxproj file: 10.0.20348.0 on both machines.
I have built up two of vsxproj files for parquet and for arrow projects.
Here is the list:
arrow - done
gandiva
generated
jni
parquet - done
plasma
skyhook
the next is probably gandiva.
I have ran along the way into an unique_ptr template compilation failure related to compressed.h CompressedOutputStream / CompressedInputStream, the
std::unique_ptr<Impl> impl_;
ended up adding
struct ARROW_NO_EXPORT ImplDeleter {
void operator()(Impl*) const;
};
std::unique_ptr<Impl, ImplDeleter> impl_;
to compile successfully.
Also, with warnings as errors a few security missing functions came up, such as getenv and strerror. Since my goal is to ensure project compiles, rather than mere adding project files, fixing those as those appear.
So, it makes me move a bit slower than I hoped, but two projects over one week is a progress. I will advance further as quickly as I can with PR.
I do feel that those project files have value to them, since complicated environment proposed in this way by means of "here is how you do it" can be an overhead. I am seeing other projects where vcxproj files are being added and it does look like a mainstream.
You can follow my progress in my fork: https://github.com/MironAtHome/arrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome edited a comment on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome edited a comment on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1015701889
Yes, I have installed those and built in two different machines, one my home laptop the other one is my work laptop.
On both I ended up installing Visual Studio 2019 and latest SDK.
Here is SDK I am referencing in my vcxproj file: 10.0.20348.0 on both machines.
I have built up two of vsxproj files for parquet and for arrow projects.
Here is the list:
arrow - done
gandiva
generated
jni
parquet - done
plasma
skyhook
the next is probably gandiva.
I have ran along the way into an unique_ptr template compilation failure related to compressed.h CompressedOutputStream / CompressedInputStream, the
std::unique_ptr<Impl> impl_;
ended up adding
struct ARROW_NO_EXPORT ImplDeleter {
void operator()(Impl*) const;
};
std::unique_ptr<Impl, ImplDeleter> impl_;
to compile successfully.
Also, with warnings as errors a few security missing functions came up, such as getenv and strerror. Since my goal is to ensure project compiles, rather than mere adding project files, fixing those as those appear.
So, it makes me move a bit slower than I hoped, but two projects over one week is a progress. I will advance further as quickly as I can with PR.
I do feel that those project files have value to them, since complicated environment proposed in this way by means of "here is how you do it" can be an overhead. I am seeing other projects where vcxproj files are being added and it does look like a mainstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome edited a comment on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome edited a comment on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1009262209
**It is my understanding that much effort is to maintain single set of scripts and use parameters to drive features / files selected for compiler to build product.
I will try to emulate it closely.
For the moment I already have vcproj project file for Visual Studio 2017 ( I believe it will work with editions 2019 and 2022 as well ). Need to
a. document dependencies
b. wire in parameters driving similar to cmake feature / file filtering
c. take a step back and consider placeholders, replaced by cmake
d. ensure and run unit tests
--- optionally / next on the list
e. add c# wrappers to some of the code using c++ CLR to provide for seamless integration with .NET
----
The advantage of having vcproj files is that anyone with Visual Studio will be able to load those, clone dependencies ( unless I missed those are submodules that just need a sync up? ) and run build. And if something fails it would be fairly transparent how and what needs to be fixed. Learning new tools, such as CMake is probably great, but it does take time. So, having vcproj is really nice to get up and running quickly.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome commented on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome commented on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1009265400
My understanding that some effort is to maintain single set of scripts and use parameters to drive features / files selected for compiler to build product.
I will try to emulate it closely.
For the moment I already have vcproj project file for Visual Studio 2017 ( I believe it will work with editions 2019 and 2022 as well ). Need to
a. document dependencies
b. wire in parameters driving similar to cmake feature / file filtering
c. take a step back and consider placeholders, replaced by cmake
d. ensure and run unit tests
--- optionally / next on the list
e. add c# wrappers to some of the code using c++ CLR to provide for seamless integration with .NET
----
The advantage of having vcproj files is that anyone with Visual Studio will be able to load those, clone dependencies ( unless I missed those are submodules that just need a sync up? ) and run build. And if something fails it would be fairly transparent how and what needs to be fixed. Learning new tools, such as CMake is probably great, but it does take time. So, having vcproj is really nice to get up and running quickly.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MironAtHome edited a comment on issue #12114: Build just doesn't work on windows with MSVC 2017. Any chance to put together decent .vcproj files?
Posted by GitBox <gi...@apache.org>.
MironAtHome edited a comment on issue #12114:
URL: https://github.com/apache/arrow/issues/12114#issuecomment-1009265400
```
My understanding is that some effort done to maintain single set of scripts and
use parameters to drive features / files selected for compiler to build
product.
I will try to emulate it closely.
For the moment I already have vcproj project file for Visual Studio 2017
( I believe it will work with editions 2019 and 2022 as well )
that builds parquet library. Need to
a. document dependencies or confirm those are submodules
b. wire in parameters driving similar to cmake feature / file filtering
c. take a step back and consider placeholders, replaced by cmake
d. ensure and run unit tests
--- optionally / next on the list
e. add c# wrappers to some of the code using c++ CLR to provide for seamless integration with .NET
f. replace getenv with updated / secure version getenv_s for test feature
----
The advantage of having vcproj files is that anyone with Visual Studio will be able to
load those, clone dependencies ( unless I missed those are submodules that just need
a sync up? ) and run build. And if something fails it would be fairly transparent how
and what needs to be fixed. Learning new tools, such as CMake is probably great, but
it does take time. So, having vcproj is really nice to get up and running quickly.
**
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org