[jira] [Commented] (SPARK-4992) Prominent Python example has bad, beginner style

["Sean Owen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-4992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260028#comment-14260028 ] 

Sean Owen commented on SPARK-4992:
----------------------------------

Seems reasonable to me, to avoid anything that could be a library or keyword, although I know just a little Python. (Does it actually fail?) What do you suggest, just "textFile" or something?

Usually you make a pull request to suggest an edit, but the site is exceptional in that it is hosted from source in Apache SVN, at https://svn.apache.org/repos/asf/spark/site You can make a patch and post it here, or I could do it pretty easily since I've done it before (hence I butted in without knowing much Python)

> Prominent Python example has bad, beginner style
> ------------------------------------------------
>
>                 Key: SPARK-4992
>                 URL: https://issues.apache.org/jira/browse/SPARK-4992
>             Project: Spark
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Eric O. LEBIGOT (EOL)
>            Priority: Trivial
>              Labels: documentation
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> In the main webpage http://spark.apache.org/, the Python example uses a variable named "file": this is a well-known bad practice (because file is the name of a built-in class).
> Such a prominently visible example should show a better mastery of Python, if Spark is to give confidence in the quality of its Python API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org