You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by aa...@apache.org on 2021/09/03 01:25:46 UTC
[hadoop] branch trunk updated: HADOOP-17874. ExceptionsHandler to
add terse/suppressed Exceptions in thread-safe manner (#3343)
This is an automated email from the ASF dual-hosted git repository.
aajisaka pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new 99a157f HADOOP-17874. ExceptionsHandler to add terse/suppressed Exceptions in thread-safe manner (#3343)
99a157f is described below
commit 99a157fa4ad174c4ff979414af2edb67a98eb9fe
Author: Viraj Jasani <vj...@apache.org>
AuthorDate: Fri Sep 3 06:55:33 2021 +0530
HADOOP-17874. ExceptionsHandler to add terse/suppressed Exceptions in thread-safe manner (#3343)
Signed-off-by: Akira Ajisaka <aa...@apache.org>
---
.../main/java/org/apache/hadoop/ipc/Server.java | 38 ++++++++--------------
1 file changed, 14 insertions(+), 24 deletions(-)
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
index bc51a70..922c6e9 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
@@ -68,6 +68,7 @@ import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicLong;
+import java.util.stream.Collectors;
import javax.security.sasl.Sasl;
import javax.security.sasl.SaslException;
@@ -184,8 +185,11 @@ public abstract class Server {
* e.g., terse exception group for concise logging messages
*/
static class ExceptionsHandler {
- private volatile Set<String> terseExceptions = new HashSet<>();
- private volatile Set<String> suppressedExceptions = new HashSet<>();
+
+ private final Set<String> terseExceptions =
+ ConcurrentHashMap.newKeySet();
+ private final Set<String> suppressedExceptions =
+ ConcurrentHashMap.newKeySet();
/**
* Add exception classes for which server won't log stack traces.
@@ -193,8 +197,10 @@ public abstract class Server {
* @param exceptionClass exception classes
*/
void addTerseLoggingExceptions(Class<?>... exceptionClass) {
- // Thread-safe replacement of terseExceptions.
- terseExceptions = addExceptions(terseExceptions, exceptionClass);
+ terseExceptions.addAll(Arrays
+ .stream(exceptionClass)
+ .map(Class::toString)
+ .collect(Collectors.toSet()));
}
/**
@@ -203,9 +209,10 @@ public abstract class Server {
* @param exceptionClass exception classes
*/
void addSuppressedLoggingExceptions(Class<?>... exceptionClass) {
- // Thread-safe replacement of suppressedExceptions.
- suppressedExceptions = addExceptions(
- suppressedExceptions, exceptionClass);
+ suppressedExceptions.addAll(Arrays
+ .stream(exceptionClass)
+ .map(Class::toString)
+ .collect(Collectors.toSet()));
}
boolean isTerseLog(Class<?> t) {
@@ -216,23 +223,6 @@ public abstract class Server {
return suppressedExceptions.contains(t.toString());
}
- /**
- * Return a new set containing all the exceptions in exceptionsSet
- * and exceptionClass.
- * @return
- */
- private static Set<String> addExceptions(
- final Set<String> exceptionsSet, Class<?>[] exceptionClass) {
- // Make a copy of the exceptionSet for performing modification
- final HashSet<String> newSet = new HashSet<>(exceptionsSet);
-
- // Add all class names into the HashSet
- for (Class<?> name : exceptionClass) {
- newSet.add(name.toString());
- }
-
- return Collections.unmodifiableSet(newSet);
- }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org