You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2026/04/13 13:42:14 UTC
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24184
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Currently Row Lineage fields can only be queried by complex expressions:
* row-id:
COALESCE(_file_row_id,
ICEBERG__FIRST__ROW__ID + FILE__POSITION)
* last-updated-sequence-number
COALESCE(_file_last_updated_sequence_number,
ICEBERG__DATA__SEQUENCE__NUMBER)
This patch adds _row_id and _last_updated_sequence_number virtual
columns to Iceberg V3 tables as syntactic sugars, i.e. they get
re-written during analysis to the corresponding COALESCE() expr.
_row_id and _last_updated_sequence_number are being used by other
engines as well, e.g. Spark.
Testing:
* e2e tests added
Generated-by: Claude Sonnet 4.6
Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/SelectList.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/VirtualColumn.java
A fe/src/main/java/org/apache/impala/rewrite/IcebergVirtualColumnRewriteRule.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-optimize.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test
9 files changed, 445 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/24184/1
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24184 )
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22121/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Apr 2026 14:03:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24184 )
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Currently Row Lineage fields can only be queried by complex expressions:
* row-id:
COALESCE(_file_row_id,
ICEBERG__FIRST__ROW__ID + FILE__POSITION)
* last-updated-sequence-number
COALESCE(_file_last_updated_sequence_number,
ICEBERG__DATA__SEQUENCE__NUMBER)
This patch adds _row_id and _last_updated_sequence_number virtual
columns to Iceberg V3 tables as syntactic sugars, i.e. they get
re-written during analysis to the corresponding COALESCE() expr.
_row_id and _last_updated_sequence_number are being used by other
engines as well, e.g. Spark.
Testing:
* e2e tests added
* column-masking tests
Generated-by: Claude Sonnet 4.6
Generated-by: Claude Opus 4.6
Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Reviewed-on: http://gerrit.cloudera.org:8080/24184
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/SelectList.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/VirtualColumn.java
A fe/src/main/java/org/apache/impala/rewrite/IcebergVirtualColumnRewriteRule.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-optimize.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test
A testdata/workloads/functional-query/queries/QueryTest/ranger_iceberg_v3_column_masking.test
M tests/authorization/test_ranger.py
11 files changed, 492 insertions(+), 33 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24184 )
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22149/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Apr 2026 17:45:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Peter Rozsa, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24184
to look at the new patch set (#3).
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Currently Row Lineage fields can only be queried by complex expressions:
* row-id:
COALESCE(_file_row_id,
ICEBERG__FIRST__ROW__ID + FILE__POSITION)
* last-updated-sequence-number
COALESCE(_file_last_updated_sequence_number,
ICEBERG__DATA__SEQUENCE__NUMBER)
This patch adds _row_id and _last_updated_sequence_number virtual
columns to Iceberg V3 tables as syntactic sugars, i.e. they get
re-written during analysis to the corresponding COALESCE() expr.
_row_id and _last_updated_sequence_number are being used by other
engines as well, e.g. Spark.
Testing:
* e2e tests added
* column-masking tests
Generated-by: Claude Sonnet 4.6
Generated-by: Claude Opus 4.6
Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/SelectList.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/VirtualColumn.java
A fe/src/main/java/org/apache/impala/rewrite/IcebergVirtualColumnRewriteRule.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-optimize.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test
A testdata/workloads/functional-query/queries/QueryTest/ranger_iceberg_v3_column_masking.test
M tests/authorization/test_ranger.py
11 files changed, 492 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/24184/3
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24184 )
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Thanks, Zoltan, I left minor comments.
http://gerrit.cloudera.org:8080/#/c/24184/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24184/1//COMMIT_MSG@26
PS1, Line 26: * e2e tests added
Please add column masking related tests for the new fields
http://gerrit.cloudera.org:8080/#/c/24184/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test:
http://gerrit.cloudera.org:8080/#/c/24184/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test@80
PS1, Line 80: # Use syntactic sugars '_row_id' and '_last_updated_sequence_number'
nit: my sugar level increased a lot from the new tests :)
http://gerrit.cloudera.org:8080/#/c/24184/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test@572
PS1, Line 572: # Both syntactic sugar columns together.
nit: the previous 2 cases has the same purpose, maybe going with the combined case is enough
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2026 12:09:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/24184 )
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Apr 2026 14:14:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24184 )
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Apr 2026 08:43:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Peter Rozsa, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24184
to look at the new patch set (#2).
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Currently Row Lineage fields can only be queried by complex expressions:
* row-id:
COALESCE(_file_row_id,
ICEBERG__FIRST__ROW__ID + FILE__POSITION)
* last-updated-sequence-number
COALESCE(_file_last_updated_sequence_number,
ICEBERG__DATA__SEQUENCE__NUMBER)
This patch adds _row_id and _last_updated_sequence_number virtual
columns to Iceberg V3 tables as syntactic sugars, i.e. they get
re-written during analysis to the corresponding COALESCE() expr.
_row_id and _last_updated_sequence_number are being used by other
engines as well, e.g. Spark.
Testing:
* e2e tests added
* column-masking tests
Generated-by: Claude Sonnet 4.6
Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/SelectList.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/VirtualColumn.java
A fe/src/main/java/org/apache/impala/rewrite/IcebergVirtualColumnRewriteRule.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-optimize.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test
A testdata/workloads/functional-query/queries/QueryTest/ranger_iceberg_v3_column_masking.test
M tests/authorization/test_ranger.py
11 files changed, 491 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/24184/2
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24184 )
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13348/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Apr 2026 09:09:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24184 )
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22155/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Apr 2026 14:26:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24184 )
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Apr 2026 09:09:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24184 )
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Apr 2026 13:35:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24184 )
Change subject: IMPALA-14825: Add syntactic sugar for Iceberg Row Lineage data
......................................................................
Patch Set 3:
(3 comments)
Thanks for the comments!
http://gerrit.cloudera.org:8080/#/c/24184/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24184/1//COMMIT_MSG@26
PS1, Line 26: * e2e tests added
> Please add column masking related tests for the new fields
Done
http://gerrit.cloudera.org:8080/#/c/24184/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test:
http://gerrit.cloudera.org:8080/#/c/24184/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test@80
PS1, Line 80: # Use syntactic sugars '_row_id' and '_last_updated_sequence_number' in time-travel query.
> nit: my sugar level increased a lot from the new tests :)
Removed a few redundant comments to decrease those sugar levels :)
http://gerrit.cloudera.org:8080/#/c/24184/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test@572
PS1, Line 572: ---- QUERY
> nit: the previous 2 cases has the same purpose, maybe going with the combin
Done
--
To view, visit http://gerrit.cloudera.org:8080/24184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02aceeb0969243ba6d28e4c0c97d5dd7a5afd765
Gerrit-Change-Number: 24184
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Apr 2026 14:04:51 +0000
Gerrit-HasComments: Yes