You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/11/13 16:08:04 UTC
[GitHub] [beam] bntnam opened a new pull request #13331: [BEAM-11219][Website revamp] Development of All about Apache Beam component
bntnam opened a new pull request #13331:
URL: https://github.com/apache/beam/pull/13331
Implemented the "All about Apache Beam component"!
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bntnam commented on a change in pull request #13331: [BEAM-11219][Website revamp] Development of All about Apache Beam component
Posted by GitBox <gi...@apache.org>.
bntnam commented on a change in pull request #13331:
URL: https://github.com/apache/beam/pull/13331#discussion_r523880699
##########
File path: website/www/site/data/en/pillars.yaml
##########
@@ -12,7 +12,13 @@
- title: Unified
body: Use a single programming model for both batch and streaming use cases.
-- title: Portable
- body: Execute pipelines on multiple execution environments.
+ icon: icons/unified-icon.svg
- title: Extensible
body: Write and share new SDKs, IO connectors, and transformation libraries.
+ icon: icons/extensive-icon.svg
+- title: Portable
+ body: Execute pipelines on multiple execution environments.
+ icon: icons/portable-icon.svg
+- title: Open Source
+ body: Use a single programming model for both batch and streaming use cases.
Review comment:
I was following the design. I believe it's just the text placeholder right now, and the copies will be updated later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bntnam commented on a change in pull request #13331: [BEAM-11219][Website revamp] Development of All about Apache Beam component
Posted by GitBox <gi...@apache.org>.
bntnam commented on a change in pull request #13331:
URL: https://github.com/apache/beam/pull/13331#discussion_r523880182
##########
File path: website/www/site/assets/icons/extensive-icon.svg
##########
@@ -0,0 +1,7 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="112" height="112" fill="none" viewBox="0 0 112 112">
+ <path fill="#FFE5D9" d="M56 112c30.928 0 56-25.072 56-56S86.928 0 56 0 0 25.072 0 56s25.072 56 56 56z"/>
+ <path fill="#FBC23E" d="M78.354 38.556v-7.83h-7.537C70.744 27.553 68.252 25 65.177 25c-3.07 0-5.568 2.553-5.64 5.726H52v7.83c3.118 0 5.646 2.63 5.646 5.871 0 3.242-2.528 5.871-5.646 5.871v7.83h7.53c0 3.243 2.529 5.872 5.647 5.872 3.118 0 5.646-2.63 5.646-5.871h7.53v-7.83c3.119 0 5.647-2.63 5.647-5.872s-2.522-5.87-5.646-5.87z"/>
+ <path fill="#FF570B" d="M71.084 83.584l7.496.027-.064-7.305c3.041-.061 5.46-2.466 5.437-5.441-.024-2.976-2.49-5.401-5.53-5.49l-.064-7.304-7.495-.027c.025 3.024-2.469 5.46-5.576 5.453-3.106-.013-5.639-2.472-5.67-5.498l-7.496-.027.066 7.3c-3.106-.014-5.602 2.428-5.576 5.452.025 3.024 2.564 5.484 5.67 5.497l.065 7.299 7.496.027c.025 3.024 2.564 5.484 5.67 5.497 3.101.006 5.597-2.436 5.571-5.46z"/>
+ <path fill="#fff" d="M52.177 38.556v-7.83h-7.772C44.33 27.553 41.754 25 38.59 25c-3.166 0-5.742 2.553-5.817 5.726H25v7.83c3.215 0 5.823 2.63 5.823 5.871 0 3.242-2.608 5.871-5.823 5.871v7.83h7.766c0 3.243 2.607 5.872 5.823 5.872 3.215 0 5.822-2.63 5.822-5.871h7.766v-7.83c3.216 0 5.823-2.63 5.823-5.872s-2.607-5.87-5.823-5.87z"/>
+ <path stroke="#000" stroke-linecap="round" stroke-width="3" d="M84 54l5-3M84.405 62.473l4.192 4.053M86 58.306l7.423.394"/>
+</svg>
Review comment:
Yes, the icons in `assets/icons` can be processed by Hugo Pipes. Thus, instead of using `<img src="./images/extensive-icon.svg`, I can use `{{ $icon := resources.Get "icon/extensive-icon.svg" }}`. With that way, I can easily access to svg code and modify it by playing around the `$icon`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13331: [BEAM-11219][Website revamp] Development of All about Apache Beam component
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13331:
URL: https://github.com/apache/beam/pull/13331#discussion_r524493084
##########
File path: website/www/site/assets/icons/extensive-icon.svg
##########
@@ -0,0 +1,7 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="112" height="112" fill="none" viewBox="0 0 112 112">
+ <path fill="#FFE5D9" d="M56 112c30.928 0 56-25.072 56-56S86.928 0 56 0 0 25.072 0 56s25.072 56 56 56z"/>
+ <path fill="#FBC23E" d="M78.354 38.556v-7.83h-7.537C70.744 27.553 68.252 25 65.177 25c-3.07 0-5.568 2.553-5.64 5.726H52v7.83c3.118 0 5.646 2.63 5.646 5.871 0 3.242-2.528 5.871-5.646 5.871v7.83h7.53c0 3.243 2.529 5.872 5.647 5.872 3.118 0 5.646-2.63 5.646-5.871h7.53v-7.83c3.119 0 5.647-2.63 5.647-5.872s-2.522-5.87-5.646-5.87z"/>
+ <path fill="#FF570B" d="M71.084 83.584l7.496.027-.064-7.305c3.041-.061 5.46-2.466 5.437-5.441-.024-2.976-2.49-5.401-5.53-5.49l-.064-7.304-7.495-.027c.025 3.024-2.469 5.46-5.576 5.453-3.106-.013-5.639-2.472-5.67-5.498l-7.496-.027.066 7.3c-3.106-.014-5.602 2.428-5.576 5.452.025 3.024 2.564 5.484 5.67 5.497l.065 7.299 7.496.027c.025 3.024 2.564 5.484 5.67 5.497 3.101.006 5.597-2.436 5.571-5.46z"/>
+ <path fill="#fff" d="M52.177 38.556v-7.83h-7.772C44.33 27.553 41.754 25 38.59 25c-3.166 0-5.742 2.553-5.817 5.726H25v7.83c3.215 0 5.823 2.63 5.823 5.871 0 3.242-2.608 5.871-5.823 5.871v7.83h7.766c0 3.243 2.607 5.872 5.823 5.872 3.215 0 5.822-2.63 5.822-5.871h7.766v-7.83c3.216 0 5.823-2.63 5.823-5.872s-2.607-5.87-5.823-5.87z"/>
+ <path stroke="#000" stroke-linecap="round" stroke-width="3" d="M84 54l5-3M84.405 62.473l4.192 4.053M86 58.306l7.423.394"/>
+</svg>
Review comment:
Ah neat, thanks for the explanation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bntnam commented on pull request #13331: [BEAM-11219][Website revamp] Development of All about Apache Beam component
Posted by GitBox <gi...@apache.org>.
bntnam commented on pull request #13331:
URL: https://github.com/apache/beam/pull/13331#issuecomment-726850252
Review: @TheNeuralBit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #13331: [BEAM-11219][Website revamp] Development of All about Apache Beam component
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #13331:
URL: https://github.com/apache/beam/pull/13331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bntnam commented on a change in pull request #13331: [BEAM-11219][Website revamp] Development of All about Apache Beam component
Posted by GitBox <gi...@apache.org>.
bntnam commented on a change in pull request #13331:
URL: https://github.com/apache/beam/pull/13331#discussion_r523880182
##########
File path: website/www/site/assets/icons/extensive-icon.svg
##########
@@ -0,0 +1,7 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="112" height="112" fill="none" viewBox="0 0 112 112">
+ <path fill="#FFE5D9" d="M56 112c30.928 0 56-25.072 56-56S86.928 0 56 0 0 25.072 0 56s25.072 56 56 56z"/>
+ <path fill="#FBC23E" d="M78.354 38.556v-7.83h-7.537C70.744 27.553 68.252 25 65.177 25c-3.07 0-5.568 2.553-5.64 5.726H52v7.83c3.118 0 5.646 2.63 5.646 5.871 0 3.242-2.528 5.871-5.646 5.871v7.83h7.53c0 3.243 2.529 5.872 5.647 5.872 3.118 0 5.646-2.63 5.646-5.871h7.53v-7.83c3.119 0 5.647-2.63 5.647-5.872s-2.522-5.87-5.646-5.87z"/>
+ <path fill="#FF570B" d="M71.084 83.584l7.496.027-.064-7.305c3.041-.061 5.46-2.466 5.437-5.441-.024-2.976-2.49-5.401-5.53-5.49l-.064-7.304-7.495-.027c.025 3.024-2.469 5.46-5.576 5.453-3.106-.013-5.639-2.472-5.67-5.498l-7.496-.027.066 7.3c-3.106-.014-5.602 2.428-5.576 5.452.025 3.024 2.564 5.484 5.67 5.497l.065 7.299 7.496.027c.025 3.024 2.564 5.484 5.67 5.497 3.101.006 5.597-2.436 5.571-5.46z"/>
+ <path fill="#fff" d="M52.177 38.556v-7.83h-7.772C44.33 27.553 41.754 25 38.59 25c-3.166 0-5.742 2.553-5.817 5.726H25v7.83c3.215 0 5.823 2.63 5.823 5.871 0 3.242-2.608 5.871-5.823 5.871v7.83h7.766c0 3.243 2.607 5.872 5.823 5.872 3.215 0 5.822-2.63 5.822-5.871h7.766v-7.83c3.216 0 5.823-2.63 5.823-5.872s-2.607-5.87-5.823-5.87z"/>
+ <path stroke="#000" stroke-linecap="round" stroke-width="3" d="M84 54l5-3M84.405 62.473l4.192 4.053M86 58.306l7.423.394"/>
+</svg>
Review comment:
Yes, `static/images` is used to store png/jpeg images. And `assets/icons` is recommended to place the svg icons. Since the icons in `assets/icons` can be processed by Hugo Pipes. Thus, instead of using `<img src="./images/extensive-icon.svg`, I can use `{{ $icon := resources.Get "icon/extensive-icon.svg" }}`. With that way, I can easily access to svg code and modify it by playing around the `$icon`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bntnam commented on a change in pull request #13331: [BEAM-11219][Website revamp] Development of All about Apache Beam component
Posted by GitBox <gi...@apache.org>.
bntnam commented on a change in pull request #13331:
URL: https://github.com/apache/beam/pull/13331#discussion_r524026653
##########
File path: website/www/site/layouts/partials/pillars/pillars-social.html
##########
@@ -0,0 +1,39 @@
+{{/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
+*/}}
+
+<div class="pillars-social-icons">
+ <div class="pillars-github-icon">
+ <a href="https://github.com/apache/beam" target="_blank">
+ {{ with resources.Get .github }}
+ {{ .Content | safeHTML }}
+ {{ end }}
+ </a>
+ </div>
+ <div class="pillars-youtube-icon">
+ <a href="https://www.youtube.com/channel/UChNnb_YO_7B0HlW6FhAXZZQ" target="_blank">
Review comment:
Thanks for your suggestion. I refactored it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bntnam commented on a change in pull request #13331: [BEAM-11219][Website revamp] Development of All about Apache Beam component
Posted by GitBox <gi...@apache.org>.
bntnam commented on a change in pull request #13331:
URL: https://github.com/apache/beam/pull/13331#discussion_r524034050
##########
File path: website/www/site/assets/icons/github-icon.svg
##########
@@ -0,0 +1,10 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" fill="none" viewBox="0 0 32 32">
Review comment:
Thanks for letting me know. As far as I know, these images are created by our designer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13331: [BEAM-11219][Website revamp] Development of All about Apache Beam component
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13331:
URL: https://github.com/apache/beam/pull/13331#discussion_r523066382
##########
File path: website/www/site/assets/icons/github-icon.svg
##########
@@ -0,0 +1,10 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" fill="none" viewBox="0 0 32 32">
Review comment:
You'll need to add a license header on these files, you can find examples in other .svg files in the repo. How were these images created, are they all original (aside from the youtube/twitter/github icons)?
##########
File path: website/www/site/layouts/partials/pillars/pillars-social.html
##########
@@ -0,0 +1,39 @@
+{{/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
+*/}}
+
+<div class="pillars-social-icons">
+ <div class="pillars-github-icon">
+ <a href="https://github.com/apache/beam" target="_blank">
+ {{ with resources.Get .github }}
+ {{ .Content | safeHTML }}
+ {{ end }}
+ </a>
+ </div>
+ <div class="pillars-youtube-icon">
+ <a href="https://www.youtube.com/channel/UChNnb_YO_7B0HlW6FhAXZZQ" target="_blank">
Review comment:
Would it be possible for these to be completely configurable like the main pillars? As it stands the data about each is spread between this file and index.html
##########
File path: website/www/site/assets/icons/extensive-icon.svg
##########
@@ -0,0 +1,7 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="112" height="112" fill="none" viewBox="0 0 112 112">
+ <path fill="#FFE5D9" d="M56 112c30.928 0 56-25.072 56-56S86.928 0 56 0 0 25.072 0 56s25.072 56 56 56z"/>
+ <path fill="#FBC23E" d="M78.354 38.556v-7.83h-7.537C70.744 27.553 68.252 25 65.177 25c-3.07 0-5.568 2.553-5.64 5.726H52v7.83c3.118 0 5.646 2.63 5.646 5.871 0 3.242-2.528 5.871-5.646 5.871v7.83h7.53c0 3.243 2.529 5.872 5.647 5.872 3.118 0 5.646-2.63 5.646-5.871h7.53v-7.83c3.119 0 5.647-2.63 5.647-5.872s-2.522-5.87-5.646-5.87z"/>
+ <path fill="#FF570B" d="M71.084 83.584l7.496.027-.064-7.305c3.041-.061 5.46-2.466 5.437-5.441-.024-2.976-2.49-5.401-5.53-5.49l-.064-7.304-7.495-.027c.025 3.024-2.469 5.46-5.576 5.453-3.106-.013-5.639-2.472-5.67-5.498l-7.496-.027.066 7.3c-3.106-.014-5.602 2.428-5.576 5.452.025 3.024 2.564 5.484 5.67 5.497l.065 7.299 7.496.027c.025 3.024 2.564 5.484 5.67 5.497 3.101.006 5.597-2.436 5.571-5.46z"/>
+ <path fill="#fff" d="M52.177 38.556v-7.83h-7.772C44.33 27.553 41.754 25 38.59 25c-3.166 0-5.742 2.553-5.817 5.726H25v7.83c3.215 0 5.823 2.63 5.823 5.871 0 3.242-2.608 5.871-5.823 5.871v7.83h7.766c0 3.243 2.607 5.872 5.823 5.872 3.215 0 5.822-2.63 5.822-5.871h7.766v-7.83c3.216 0 5.823-2.63 5.823-5.872s-2.607-5.87-5.823-5.87z"/>
+ <path stroke="#000" stroke-linecap="round" stroke-width="3" d="M84 54l5-3M84.405 62.473l4.192 4.053M86 58.306l7.423.394"/>
+</svg>
Review comment:
Is there a reason these files are in `assets/icons`? It looks like the rest of our images are in [`static/images`](https://github.com/apache/beam/tree/website-revamp/website/www/site/static/images)
##########
File path: website/www/site/data/en/pillars.yaml
##########
@@ -12,7 +12,13 @@
- title: Unified
body: Use a single programming model for both batch and streaming use cases.
-- title: Portable
- body: Execute pipelines on multiple execution environments.
+ icon: icons/unified-icon.svg
- title: Extensible
body: Write and share new SDKs, IO connectors, and transformation libraries.
+ icon: icons/extensive-icon.svg
+- title: Portable
+ body: Execute pipelines on multiple execution environments.
+ icon: icons/portable-icon.svg
+- title: Open Source
+ body: Use a single programming model for both batch and streaming use cases.
Review comment:
Is this a typo? This is the same body as "Unified"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org