You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oozie.apache.org by "Mohammad Kamrul Islam (JIRA)" <ji...@apache.org> on 2011/09/14 05:02:08 UTC
[jira] [Created] (OOZIE-558) Modify bin/mkdistro.sh to refer to svn
instead of git
Modify bin/mkdistro.sh to refer to svn instead of git
-----------------------------------------------------
Key: OOZIE-558
URL: https://issues.apache.org/jira/browse/OOZIE-558
Project: Oozie
Issue Type: Task
Reporter: Mohammad Kamrul Islam
export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
# Out canonical repo is @GitHub -- hence hardcoding
export VC_URL="git://github.com/yahoo/oozie.git"
Should be replaced by
export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104233#comment-13104233 ]
jiraposter@reviews.apache.org commented on OOZIE-558:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1850/#review1884
-----------------------------------------------------------
+1
- Angelo K.
On 2011-09-14 03:08:33, Mohammad Islam wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1850/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-14 03:08:33)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Modify bin/mkdistro.sh to refer to svn instead of git
bq.
bq.
bq. This addresses bug OOZIE-558.
bq. https://issues.apache.org/jira/browse/OOZIE-558
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh 1170386
bq.
bq. Diff: https://reviews.apache.org/r/1850/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mohammad
bq.
bq.
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106698#comment-13106698 ]
jiraposter@reviews.apache.org commented on OOZIE-558:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1850/#review1938
-----------------------------------------------------------
Ship it!
- Alejandro
On 2011-09-16 18:38:09, Mohammad Islam wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1850/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-16 18:38:09)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Modify bin/mkdistro.sh to refer to svn instead of git
bq.
bq.
bq. This addresses bug OOZIE-558.
bq. https://issues.apache.org/jira/browse/OOZIE-558
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh 1170386
bq.
bq. Diff: https://reviews.apache.org/r/1850/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mohammad
bq.
bq.
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106673#comment-13106673 ]
jiraposter@reviews.apache.org commented on OOZIE-558:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1850/
-----------------------------------------------------------
(Updated 2011-09-16 18:38:09.218844)
Review request for oozie.
Changes
-------
Addressing the new comment.
Summary
-------
Modify bin/mkdistro.sh to refer to svn instead of git
This addresses bug OOZIE-558.
https://issues.apache.org/jira/browse/OOZIE-558
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh 1170386
Diff: https://reviews.apache.org/r/1850/diff
Testing
-------
Thanks,
Mohammad
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105898#comment-13105898 ]
jiraposter@reviews.apache.org commented on OOZIE-558:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1850/#review1923
-----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh
<https://reviews.apache.org/r/1850/#comment4415>
I would not use the canonical repo by the current repo 'origin' remote. That will indicate from where the commit is.
Other than that looks good, +1
- Alejandro
On 2011-09-16 03:11:33, Mohammad Islam wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1850/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-16 03:11:33)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Modify bin/mkdistro.sh to refer to svn instead of git
bq.
bq.
bq. This addresses bug OOZIE-558.
bq. https://issues.apache.org/jira/browse/OOZIE-558
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh 1170386
bq.
bq. Diff: https://reviews.apache.org/r/1850/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mohammad
bq.
bq.
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "Angelo K. Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104232#comment-13104232 ]
Angelo K. Huang commented on OOZIE-558:
---------------------------------------
Not sure which place I should comment, so comment both.
+1
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104200#comment-13104200 ]
jiraposter@reviews.apache.org commented on OOZIE-558:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1850/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
Modify bin/mkdistro.sh to refer to svn instead of git
This addresses bug OOZIE-558.
https://issues.apache.org/jira/browse/OOZIE-558
Diffs
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh 1170386
Diff: https://reviews.apache.org/r/1850/diff
Testing
-------
Thanks,
Mohammad
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105909#comment-13105909 ]
jiraposter@reviews.apache.org commented on OOZIE-558:
-----------------------------------------------------
bq. On 2011-09-16 06:31:13, Alejandro Abdelnur wrote:
bq. >
Not clear about "canonical" repo and origin remote.
Would you please explain what are those two options. Also what to modify is not clear.
- Mohammad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1850/#review1923
-----------------------------------------------------------
On 2011-09-16 03:11:33, Mohammad Islam wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1850/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-16 03:11:33)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Modify bin/mkdistro.sh to refer to svn instead of git
bq.
bq.
bq. This addresses bug OOZIE-558.
bq. https://issues.apache.org/jira/browse/OOZIE-558
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh 1170386
bq.
bq. Diff: https://reviews.apache.org/r/1850/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mohammad
bq.
bq.
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "Mohammad Kamrul Islam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mohammad Kamrul Islam reassigned OOZIE-558:
-------------------------------------------
Assignee: Mohammad Kamrul Islam
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "Mohammad Kamrul Islam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mohammad Kamrul Islam resolved OOZIE-558.
-----------------------------------------
Resolution: Fixed
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105826#comment-13105826 ]
jiraposter@reviews.apache.org commented on OOZIE-558:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1850/
-----------------------------------------------------------
(Updated 2011-09-16 03:11:33.407860)
Review request for oozie.
Changes
-------
Including the comments of supporting svn/git.
Summary
-------
Modify bin/mkdistro.sh to refer to svn instead of git
This addresses bug OOZIE-558.
https://issues.apache.org/jira/browse/OOZIE-558
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh 1170386
Diff: https://reviews.apache.org/r/1850/diff
Testing
-------
Thanks,
Mohammad
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104658#comment-13104658 ]
jiraposter@reviews.apache.org commented on OOZIE-558:
-----------------------------------------------------
bq. On 2011-09-14 14:05:04, Alejandro Abdelnur wrote:
bq. > As we are planning to get a GIT mirror, we should keep the GIT logic (using the origin remote) and the logic should check for GIT & SVN something like the following:
bq. >
bq. > if SVN installed
bq. > if repo is SVN
bq. > get SVN repo/revision info
bq. > if repo/revision not set
bq. > if GIT installed
bq. > get GIT repo/revision info
bq. > if repo/revision not set
bq. > set repo/revision to unavail
bq. >
Do we get mirror automatically?
- Angelo K.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1850/#review1889
-----------------------------------------------------------
On 2011-09-14 03:08:33, Mohammad Islam wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1850/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-14 03:08:33)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Modify bin/mkdistro.sh to refer to svn instead of git
bq.
bq.
bq. This addresses bug OOZIE-558.
bq. https://issues.apache.org/jira/browse/OOZIE-558
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh 1170386
bq.
bq. Diff: https://reviews.apache.org/r/1850/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mohammad
bq.
bq.
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104511#comment-13104511 ]
jiraposter@reviews.apache.org commented on OOZIE-558:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1850/#review1889
-----------------------------------------------------------
As we are planning to get a GIT mirror, we should keep the GIT logic (using the origin remote) and the logic should check for GIT & SVN something like the following:
if SVN installed
if repo is SVN
get SVN repo/revision info
if repo/revision not set
if GIT installed
get GIT repo/revision info
if repo/revision not set
set repo/revision to unavail
- Alejandro
On 2011-09-14 03:08:33, Mohammad Islam wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1850/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-14 03:08:33)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Modify bin/mkdistro.sh to refer to svn instead of git
bq.
bq.
bq. This addresses bug OOZIE-558.
bq. https://issues.apache.org/jira/browse/OOZIE-558
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh 1170386
bq.
bq. Diff: https://reviews.apache.org/r/1850/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mohammad
bq.
bq.
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104666#comment-13104666 ]
jiraposter@reviews.apache.org commented on OOZIE-558:
-----------------------------------------------------
bq. On 2011-09-14 14:05:04, Alejandro Abdelnur wrote:
bq. > As we are planning to get a GIT mirror, we should keep the GIT logic (using the origin remote) and the logic should check for GIT & SVN something like the following:
bq. >
bq. > if SVN installed
bq. > if repo is SVN
bq. > get SVN repo/revision info
bq. > if repo/revision not set
bq. > if GIT installed
bq. > get GIT repo/revision info
bq. > if repo/revision not set
bq. > set repo/revision to unavail
bq. >
bq.
bq. Angelo K. Huang wrote:
bq. Do we get mirror automatically?
we have to ask to infra-dev@ to do so. If Mohammad didn't ask them yet, I can shoot an email/open-JIRA
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1850/#review1889
-----------------------------------------------------------
On 2011-09-14 03:08:33, Mohammad Islam wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1850/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-14 03:08:33)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Modify bin/mkdistro.sh to refer to svn instead of git
bq.
bq.
bq. This addresses bug OOZIE-558.
bq. https://issues.apache.org/jira/browse/OOZIE-558
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh 1170386
bq.
bq. Diff: https://reviews.apache.org/r/1850/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mohammad
bq.
bq.
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-558) Modify bin/mkdistro.sh to refer to
svn instead of git
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105930#comment-13105930 ]
jiraposter@reviews.apache.org commented on OOZIE-558:
-----------------------------------------------------
bq. On 2011-09-16 06:31:13, Alejandro Abdelnur wrote:
bq. >
bq.
bq. Mohammad Islam wrote:
bq. Not clear about "canonical" repo and origin remote.
bq. Would you please explain what are those two options. Also what to modify is not clear.
bq.
I've meant the GIT repo URL should be obtained as follows:
git remote -v | grep origin | grep fetch | awk '{print $2}'
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1850/#review1923
-----------------------------------------------------------
On 2011-09-16 03:11:33, Mohammad Islam wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1850/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-16 03:11:33)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Modify bin/mkdistro.sh to refer to svn instead of git
bq.
bq.
bq. This addresses bug OOZIE-558.
bq. https://issues.apache.org/jira/browse/OOZIE-558
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh 1170386
bq.
bq. Diff: https://reviews.apache.org/r/1850/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mohammad
bq.
bq.
> Modify bin/mkdistro.sh to refer to svn instead of git
> -----------------------------------------------------
>
> Key: OOZIE-558
> URL: https://issues.apache.org/jira/browse/OOZIE-558
> Project: Oozie
> Issue Type: Task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> export VC_REV=`git branch -v | awk '/^\*/ {printf("%s@%s\n", $2, $3); }'`
> # Out canonical repo is @GitHub -- hence hardcoding
> export VC_URL="git://github.com/yahoo/oozie.git"
> Should be replaced by
> export VC_REV=`svn info | grep "Revision" | awk '{print $2}'`
> export VC_URL=`svn info | grep "URL" | awk '{print $2}'`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira