You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by da...@apache.org on 2026/05/22 10:22:09 UTC
(causeway) 01/02: CAUSEWAY-3998: refinements
This is an automated email from the ASF dual-hosted git repository.
danhaywood pushed a commit to branch 3998-v2
in repository https://gitbox.apache.org/repos/asf/causeway.git
commit 28c98ed6d6883df4a0649b2d327372011a63a3bc
Author: Dan Haywood <da...@haywood-associates.co.uk>
AuthorDate: Fri May 22 11:16:12 2026 +0100
CAUSEWAY-3998: refinements
import commands when open CommandReplayManager
add openTarget
---
.../applib/CausewayModuleExtCommandLogApplib.java | 2 ++
.../extensions/commandlog/applib/app/CommandLogMenu.java | 13 +++++++++++--
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/CausewayModuleExtCommandLogApplib.java b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/CausewayModuleExtCommandLogApplib.java
index 990d30772d9..81cfb51715b 100644
--- a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/CausewayModuleExtCommandLogApplib.java
+++ b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/CausewayModuleExtCommandLogApplib.java
@@ -41,6 +41,7 @@
import org.apache.causeway.extensions.commandlog.applib.dom.replay.ReplayableCommand_excludeFromReplay;
import org.apache.causeway.extensions.commandlog.applib.dom.replay.ReplayableCommand_makeExportable;
import org.apache.causeway.extensions.commandlog.applib.dom.replay.ReplayableCommand_openCommandLogEntry;
+import org.apache.causeway.extensions.commandlog.applib.dom.replay.ReplayableCommand_openTarget;
import org.apache.causeway.extensions.commandlog.applib.dom.replay.ReplayableCommand_replayOrRetry;
import org.apache.causeway.extensions.commandlog.applib.fakescheduler.FakeScheduler;
import org.apache.causeway.extensions.commandlog.applib.job.BackgroundCommandsJobControl;
@@ -69,6 +70,7 @@
CommandLogEntry_siblingCommands.class,
ReplayableCommand_makeExportable.class,
ReplayableCommand_openCommandLogEntry.class,
+ ReplayableCommand_openTarget.class,
ReplayableCommand_replayOrRetry.class,
ReplayableCommand_excludeFromReplay.class,
ReplayableCommand_delete.class,
diff --git a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/app/CommandLogMenu.java b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/app/CommandLogMenu.java
index 507775f194b..8501d801aa5 100644
--- a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/app/CommandLogMenu.java
+++ b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/app/CommandLogMenu.java
@@ -23,6 +23,7 @@
import java.time.ZoneId;
import java.time.temporal.ChronoUnit;
import java.util.List;
+import java.util.Optional;
import javax.inject.Inject;
import javax.inject.Named;
@@ -32,6 +33,7 @@
import org.apache.causeway.applib.annotation.DomainService;
import org.apache.causeway.applib.annotation.DomainServiceLayout;
import org.apache.causeway.applib.annotation.MemberSupport;
+import org.apache.causeway.applib.annotation.Optionality;
import org.apache.causeway.applib.annotation.Parameter;
import org.apache.causeway.applib.annotation.ParameterLayout;
import org.apache.causeway.applib.annotation.PriorityPrecedence;
@@ -50,6 +52,8 @@
import org.jspecify.annotations.NonNull;
import org.springframework.lang.Nullable;
+import jnr.a64asm.OP;
+
import lombok.RequiredArgsConstructor;
/**
@@ -192,12 +196,17 @@ public class replayManager {
public class DomainEvent extends ActionDomainEvent<replayManager> { }
@MemberSupport public CommandReplayManager act(
- @Parameter(fileAccept = ".yml,.yaml")
+ @Parameter(
+ optionality = Optionality.OPTIONAL,
+ fileAccept = ".yml,.yaml"
+ )
final Blob commandsYaml
) {
final var now = clockService.getClock().nowAsJavaSqlTimestamp();
final var commandReplayManager = new CommandReplayManager(now, replayContext);
- return importCommands(commandReplayManager).act(commandsYaml, true);
+ return Optional.ofNullable(commandsYaml)
+ .map(yaml -> importCommands(commandReplayManager).act(yaml, true))
+ .orElse(commandReplayManager);
}
private CommandReplayManager.importCommands importCommands(CommandReplayManager commandReplayManager) {