You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/04/14 20:48:12 UTC

Re: [PR] Support `GenericListViewArray::new_unchecked` and refactor `ListView` json decoder [arrow-rs]

alamb commented on code in PR #9648:
URL: https://github.com/apache/arrow-rs/pull/9648#discussion_r3082370967


##########
arrow-array/src/array/list_view_array.rs:
##########
@@ -223,6 +223,34 @@ impl<OffsetSize: OffsetSizeTrait> GenericListViewArray<OffsetSize> {
         Self::try_new(field, offsets, sizes, values, nulls).unwrap()
     }
 
+    /// Create a new [`GenericListViewArray`] from the provided parts without validation
+    ///
+    /// See [`Self::try_new`] for the checked version of this function, and the
+    /// documentation of that function for the invariants that must be upheld.
+    ///
+    /// # Safety
+    ///
+    /// Safe if [`Self::new`] would not panic with the given arguments

Review Comment:
   ```suggestion
       /// The parts must be a valid ListViewArray according to the Arrow spec.
       /// See [`Self::try_new`] for details
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org