[GitHub] [airflow] mik-laj commented on a change in pull request #5909: [AIRFLOW-4391] Fix tooltip for None-State Tasks in 'Recent Tasks'

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #5909: [AIRFLOW-4391] Fix tooltip for None-State Tasks in 'Recent Tasks'
URL: https://github.com/apache/airflow/pull/5909#discussion_r317369703
 
 

 ##########
 File path: airflow/www/templates/airflow/dags.html
 ##########
 @@ -403,7 +403,13 @@ <h2>DAGs</h2>
       });
       d3.json("{{ url_for('Airflow.task_stats') }}", function(error, json) {
         for(var dag_id in json) {
-            states = json[dag_id];
+            states = json[dag_id].map(task => {
 
 Review comment:
   Why not pass another value to d3 if it causes problems?
   It seems much simpler to me
   
   Line 366
   ```diff
   -              .attr('title', function(d) {return d.state})
   +              .attr('title', function(d) {return d.state || 'none' })
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services