[GitHub] [pulsar] 315157973 removed a comment on pull request #9163: Avoid enable DLQ on Key_Shared subscription.

[GitBox <gi...@apache.org>]

315157973 removed a comment on pull request #9163:
URL: https://github.com/apache/pulsar/pull/9163#issuecomment-757893221


   The same logic exists in the void messageReceived method. Is it better for us to  prohibit setting this kind of policy in the builder ?
   ```
   if (deadLetterPolicy != null && possibleSendToDeadLetterTopicMessages != null && redeliveryCount >= deadLetterPolicy.getMaxRedeliverCount()) {
       possibleSendToDeadLetterTopicMessages.put((MessageIdImpl)message.getMessageId(), Collections.singletonList(message));
   }
   ```
   There is retry logic in `deadLetterPolicy`. If the number of retries is exceeded, how to deal with these messages? But the `deadLetterProducer` in `consumerImpl` doesn't seem to do any processing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org