You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/05 11:22:13 UTC

[GitHub] [arrow] alamb commented on a change in pull request #9889: ARROW-12204: [Rust][CI] Reduce size of Rust build artifacts in integration test

alamb commented on a change in pull request #9889:
URL: https://github.com/apache/arrow/pull/9889#discussion_r607040821



##########
File path: ci/scripts/rust_build.sh
##########
@@ -21,6 +21,10 @@ set -ex
 
 source_dir=${1}/rust
 
+# This file is used to build the rust binaries needed for the

Review comment:
       Doing a full rust build as part of the integration test appears to be unecessary

##########
File path: rust/datafusion/src/execution/dataframe_impl.rs
##########
@@ -15,7 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//! Implementation of DataFrame API
+//! Implementation of DataFrame API. 

Review comment:
       this is here to force the rust + integration tests to run




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org