You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Haoxiang Ma <mh...@gmail.com> on 2020/04/10 11:47:09 UTC

Review Request 72346: RANGER-2789: GET API service/xusers/users turns very slow when there are more than 1000 users

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72346/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-2789
    https://issues.apache.org/jira/browse/RANGER-2789


Repository: ranger


Description
-------

GET API service/xusers/users turns very slow when there are more than 1000 users


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java 1e41e708a 
  security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 0464e7b6e 
  security-admin/src/main/java/org/apache/ranger/service/XUserService.java 6ff8823da 
  security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 9cdc14ebf 
  security-admin/src/main/java/org/apache/ranger/view/VXUser.java 96f6468f7 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 22e71e549 


Diff: https://reviews.apache.org/r/72346/diff/1/


Testing
-------

1.Compilation OK
2.Already used in production environment


Thanks,

Haoxiang Ma

Re: Review Request 72346: RANGER-2789: GET API service/xusers/users turns very slow when there are more than 1000 users

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72346/#review220925
-----------------------------------------------------------




security-admin/src/main/resources/META-INF/jpa_named_queries.xml
Lines 227 (patched)
<https://reviews.apache.org/r/72346/#comment309641>

    This will be  removed if you are considering to implement feedback given by madhan


- Pradeep Agrawal


On May 31, 2020, 4:11 p.m., Haoxiang Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72346/
> -----------------------------------------------------------
> 
> (Updated May 31, 2020, 4:11 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2789
>     https://issues.apache.org/jira/browse/RANGER-2789
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> GET API service/xusers/users turns very slow when there are more than 1000 users
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java 1e41e708a 
>   security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 0464e7b6e 
>   security-admin/src/main/java/org/apache/ranger/service/XUserService.java 6ff8823da 
>   security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 9cdc14ebf 
>   security-admin/src/main/java/org/apache/ranger/view/VXUser.java 96f6468f7 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 22e71e549 
> 
> 
> Diff: https://reviews.apache.org/r/72346/diff/1/
> 
> 
> Testing
> -------
> 
> 1.Compilation OK
> 2.Already used in production environment
> 
> 
> File Attachments
> ----------------
> 
> RANGER-2789.patch
>   https://reviews.apache.org/media/uploaded/files/2020/05/29/419dc717-cec5-4dfe-b3cc-28e99f94884d__RANGER-2789.patch
> 
> 
> Thanks,
> 
> Haoxiang Ma
> 
>

Re: Review Request 72346: RANGER-2789: GET API service/xusers/users turns very slow when there are more than 1000 users

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72346/#review220924
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java
Lines 69 (patched)
<https://reviews.apache.org/r/72346/#comment309637>

    The issue is not resolved, reopening it again



security-admin/src/main/java/org/apache/ranger/entity/XXUser.java
Lines 290 (patched)
<https://reviews.apache.org/r/72346/#comment309638>

    Not fixed , reopening now.



security-admin/src/main/java/org/apache/ranger/view/VXUser.java
Lines 315 (patched)
<https://reviews.apache.org/r/72346/#comment309639>

    Not fixed, reopening now



security-admin/src/main/java/org/apache/ranger/view/VXUser.java
Lines 323 (patched)
<https://reviews.apache.org/r/72346/#comment309640>

    Not fixed, reopening now


- Pradeep Agrawal


On May 31, 2020, 4:11 p.m., Haoxiang Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72346/
> -----------------------------------------------------------
> 
> (Updated May 31, 2020, 4:11 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2789
>     https://issues.apache.org/jira/browse/RANGER-2789
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> GET API service/xusers/users turns very slow when there are more than 1000 users
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java 1e41e708a 
>   security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 0464e7b6e 
>   security-admin/src/main/java/org/apache/ranger/service/XUserService.java 6ff8823da 
>   security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 9cdc14ebf 
>   security-admin/src/main/java/org/apache/ranger/view/VXUser.java 96f6468f7 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 22e71e549 
> 
> 
> Diff: https://reviews.apache.org/r/72346/diff/1/
> 
> 
> Testing
> -------
> 
> 1.Compilation OK
> 2.Already used in production environment
> 
> 
> File Attachments
> ----------------
> 
> RANGER-2789.patch
>   https://reviews.apache.org/media/uploaded/files/2020/05/29/419dc717-cec5-4dfe-b3cc-28e99f94884d__RANGER-2789.patch
> 
> 
> Thanks,
> 
> Haoxiang Ma
> 
>

Re: Review Request 72346: RANGER-2789: GET API service/xusers/users turns very slow when there are more than 1000 users

Posted by Haoxiang Ma <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72346/
-----------------------------------------------------------

(Updated ε…­ζœˆ 1, 2020, 7:43 a.m.)


Review request for ranger.


Bugs: RANGER-2789
    https://issues.apache.org/jira/browse/RANGER-2789


Repository: ranger


Description
-------

GET API service/xusers/users turns very slow when there are more than 1000 users


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 0464e7b6e 
  security-admin/src/main/java/org/apache/ranger/service/XUserService.java 6ff8823da 
  security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 9cdc14ebf 
  security-admin/src/main/java/org/apache/ranger/view/VXUser.java 96f6468f7 


Diff: https://reviews.apache.org/r/72346/diff/2/

Changes: https://reviews.apache.org/r/72346/diff/1-2/


Testing
-------

1.Compilation OK
2.Already used in production environment


File Attachments
----------------

RANGER-2789.patch
  https://reviews.apache.org/media/uploaded/files/2020/05/29/419dc717-cec5-4dfe-b3cc-28e99f94884d__RANGER-2789.patch


Thanks,

Haoxiang Ma

Re: Review Request 72346: RANGER-2789: GET API service/xusers/users turns very slow when there are more than 1000 users

Posted by Haoxiang Ma <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72346/
-----------------------------------------------------------

(Updated δΊ”ζœˆ 31, 2020, 4:11 p.m.)


Review request for ranger.


Bugs: RANGER-2789
    https://issues.apache.org/jira/browse/RANGER-2789


Repository: ranger


Description
-------

GET API service/xusers/users turns very slow when there are more than 1000 users


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java 1e41e708a 
  security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 0464e7b6e 
  security-admin/src/main/java/org/apache/ranger/service/XUserService.java 6ff8823da 
  security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 9cdc14ebf 
  security-admin/src/main/java/org/apache/ranger/view/VXUser.java 96f6468f7 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 22e71e549 


Diff: https://reviews.apache.org/r/72346/diff/1/


Testing
-------

1.Compilation OK
2.Already used in production environment


File Attachments (updated)
----------------

RANGER-2789.patch
  https://reviews.apache.org/media/uploaded/files/2020/05/29/419dc717-cec5-4dfe-b3cc-28e99f94884d__RANGER-2789.patch


Thanks,

Haoxiang Ma

Re: Review Request 72346: RANGER-2789: GET API service/xusers/users turns very slow when there are more than 1000 users

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72346/#review220854
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java
Lines 69 (patched)
<https://reviews.apache.org/r/72346/#comment309575>

    Consider using BaseDao.getAll(), instead of introducing this method; named query 'XXGroupUser.findAllXXGroupUser' will not be needed with this change.



security-admin/src/main/java/org/apache/ranger/entity/XXUser.java
Lines 290 (patched)
<https://reviews.apache.org/r/72346/#comment309574>

    For simplicity, consider using Objects.hash(), as below:
      return Objects.hash(super.hashCode(), name, description, status, credStoreId);



security-admin/src/main/java/org/apache/ranger/view/VXUser.java
Lines 315 (patched)
<https://reviews.apache.org/r/72346/#comment309577>

    For simplicity, consider using Objects.equals(), like below:
     return Objects.equals(status, vxUser.status) &&
            Objects.equals(name, vxUser.name) &&
            Objects.equals(description, vxUser.description) &&
            Objects.equals(credStoreId, vxUser.credStoreId);



security-admin/src/main/java/org/apache/ranger/view/VXUser.java
Lines 323 (patched)
<https://reviews.apache.org/r/72346/#comment309576>

    For simplicity, consider using Objects.hash(), like below:
     return Objects.hash(super.hashCode(), name, description, credStoreId, status);


- Madhan Neethiraj


On April 10, 2020, 11:47 a.m., Haoxiang Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72346/
> -----------------------------------------------------------
> 
> (Updated April 10, 2020, 11:47 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2789
>     https://issues.apache.org/jira/browse/RANGER-2789
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> GET API service/xusers/users turns very slow when there are more than 1000 users
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java 1e41e708a 
>   security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 0464e7b6e 
>   security-admin/src/main/java/org/apache/ranger/service/XUserService.java 6ff8823da 
>   security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 9cdc14ebf 
>   security-admin/src/main/java/org/apache/ranger/view/VXUser.java 96f6468f7 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 22e71e549 
> 
> 
> Diff: https://reviews.apache.org/r/72346/diff/1/
> 
> 
> Testing
> -------
> 
> 1.Compilation OK
> 2.Already used in production environment
> 
> 
> Thanks,
> 
> Haoxiang Ma
> 
>

Re: Review Request 72346: RANGER-2789: GET API service/xusers/users turns very slow when there are more than 1000 users

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72346/#review220852
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On April 10, 2020, 11:47 a.m., Haoxiang Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72346/
> -----------------------------------------------------------
> 
> (Updated April 10, 2020, 11:47 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2789
>     https://issues.apache.org/jira/browse/RANGER-2789
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> GET API service/xusers/users turns very slow when there are more than 1000 users
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java 1e41e708a 
>   security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 0464e7b6e 
>   security-admin/src/main/java/org/apache/ranger/service/XUserService.java 6ff8823da 
>   security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 9cdc14ebf 
>   security-admin/src/main/java/org/apache/ranger/view/VXUser.java 96f6468f7 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 22e71e549 
> 
> 
> Diff: https://reviews.apache.org/r/72346/diff/1/
> 
> 
> Testing
> -------
> 
> 1.Compilation OK
> 2.Already used in production environment
> 
> 
> Thanks,
> 
> Haoxiang Ma
> 
>