[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7959: [WIP] [7867] Handle Select * with Extra Columns

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7959:
URL: https://github.com/apache/pinot/pull/7959#discussion_r791006174



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -1487,6 +1498,41 @@ static void updateColumnNames(String rawTableName, PinotQuery pinotQuery, boolea
     }
   }
 
+  private static void expandStarExpressionToActualColumns(PinotQuery pinotQuery, Map<String, String> columnNameMap,
+      Expression selectStarExpr) {
+    List<Expression> originalSelections = pinotQuery.getSelectList();
+    Set<String> originallySelectedColumnNames =

Review comment:
       Avoid using stream apis in query path because we have found that it has poorer performance comparing to regular apis.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org