You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jamesnetherton (via GitHub)" <gi...@apache.org> on 2023/08/23 07:44:09 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request, #5215: Populate FastComponentNameResolver component names from included component service paths
jamesnetherton opened a new pull request, #5215:
URL: https://github.com/apache/camel-quarkus/pull/5215
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #5215: Populate FastComponentNameResolver component names from included component service paths
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #5215:
URL: https://github.com/apache/camel-quarkus/pull/5215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #5215: Populate FastComponentNameResolver component names from included component service paths
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #5215:
URL: https://github.com/apache/camel-quarkus/pull/5215#issuecomment-1690002114
The Hazelcast failure is a known flake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5215: Populate FastComponentNameResolver component names from included component service paths
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5215:
URL: https://github.com/apache/camel-quarkus/pull/5215#discussion_r1302732600
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelProcessor.java:
##########
@@ -399,15 +395,19 @@ public List<CamelRoutesBuilderClassBuildItem> discoverRoutesBuilderClassNames(
@Record(ExecutionTime.STATIC_INIT)
@BuildStep
CamelComponentNameResolverBuildItem componentNameResolver(
- BuildTimeCamelCatalogBuildItem camelCatalog,
Review Comment:
OK, I get it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #5215: Populate FastComponentNameResolver component names from included component service paths
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #5215:
URL: https://github.com/apache/camel-quarkus/pull/5215#discussion_r1302700831
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelProcessor.java:
##########
@@ -399,15 +395,19 @@ public List<CamelRoutesBuilderClassBuildItem> discoverRoutesBuilderClassNames(
@Record(ExecutionTime.STATIC_INIT)
@BuildStep
CamelComponentNameResolverBuildItem componentNameResolver(
- BuildTimeCamelCatalogBuildItem camelCatalog,
Review Comment:
It is used elsewhere. To figure out which types can be made unremovable, just in case folks want to use CDI to wire up components etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5215: Populate FastComponentNameResolver component names from included component service paths
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5215:
URL: https://github.com/apache/camel-quarkus/pull/5215#discussion_r1302697464
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelProcessor.java:
##########
@@ -399,15 +395,19 @@ public List<CamelRoutesBuilderClassBuildItem> discoverRoutesBuilderClassNames(
@Record(ExecutionTime.STATIC_INIT)
@BuildStep
CamelComponentNameResolverBuildItem componentNameResolver(
- BuildTimeCamelCatalogBuildItem camelCatalog,
Review Comment:
It seems that `BuildTimeCamelCatalog` no other usage if we remove here. Just curious, what's the original idea about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #5215: Populate FastComponentNameResolver component names from included component service paths
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #5215:
URL: https://github.com/apache/camel-quarkus/pull/5215#issuecomment-1689485175
> And actually, maybe it also help with custom component. Like custom component would not be present in the catalog and would be missed before this pr. Does is sound right ?
Yes, exactly. I did not consider custom components when I wrote the initial implementation of `FastComponentNameResolver`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #5215: Populate FastComponentNameResolver component names from included component service paths
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #5215:
URL: https://github.com/apache/camel-quarkus/pull/5215#issuecomment-1689619740
Looks like I need to choose a difference component to exclude as of course `bean` is used when the tests run 'grouped'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org