You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/10/08 09:07:46 UTC
[GitHub] [hive] deniskuzZ commented on pull request #2657: HIVE-25540 : Enable batch updation of column stats only for MySql and Postgres
deniskuzZ commented on pull request #2657:
URL: https://github.com/apache/hive/pull/2657#issuecomment-938477954
> I would guess that the Derby is also covered by the unit tests.
>
> Maybe it would be better to test with other databases unless we know there are some known issues which are hard to mitigate. The best would be to add an appropriate test to the [TestHiveMetastore.java](https://github.com/apache/hive/blob/07464b12ada011f13546b3d5d37276b76218416c/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java)
>
> I see a [testColumnStatistics](https://github.com/apache/hive/blob/07464b12ada011f13546b3d5d37276b76218416c/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java#L1674) method. This might be the one that we need, and we only have to run the tests against a cluster like described here: See: https://cwiki.apache.org/confluence/display/Hive/MetaStore+API+tests#MetaStoreAPITests-IMetaStoreClientTests
>
> You can use Docker images defined here to set up the db to test agains: https://github.com/apache/hive/blob/master/standalone-metastore/DEV-README
>
> @deniskuzZ: Is there a faster way to test out the changes against multiple databases?
>
> Thanks, Peter
use ITestDbTxnManager:
````
mvn test -Dtest=ITestDbTxnManager -Dtest.metastore.db=mysql -Ditest.jdbc.jars=mysql-connector-java-5.1.49.jar
mvn test -Dtest=ITestDbTxnManager -Dtest.metastore.db=postgres -Ditest.jdbc.jars=postgresql-42.2.23.jar
mvn test -Dtest=ITestDbTxnManager -Dtest.metastore.db=oracle -Ditest.jdbc.jars=ojdbc8.jar
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org