[jira] [Commented] (TINKERPOP-1679) Detached side-effects aren't attached when remoted

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095345#comment-16095345 ] 

ASF GitHub Bot commented on TINKERPOP-1679:
-------------------------------------------

GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/679

    TINKERPOP-1679: Detached side-effects aren't attached when remoted

    https://issues.apache.org/jira/browse/TINKERPOP-1679
    
    This was occurring because Gremlin-Python did not have serializers for the Graph elements. I created serializers which are of the `ReferenceXXX` form. I added serializer tests as well as add an `AddEdgeTest` and specific Gremlin-Python test for the traversal specified in the ticket. I also exposed two `ProjectTest` `OPT_OUTs` in `RemoteGraph`. I don't know why those were `OPT_OUT` as OLAP will automatically fail accordingly beyond the star graph.
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1679

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #679
    
----
commit 1f8239834b0c911f7d53d25a37cbee0ef26a66fc
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2017-07-20T20:44:02Z

    added AddEdgeTest that leverages side-effect data to ensure Attachables are respected. Exposed PropertyTests that were OPT_OUT in RemoteGraph, but didn't need to be. Added a Python test to verify the specific ticket test passes (though tested in ProcessTestSuite). The real problem is that Python does not have Serializers for Graph elements. It only has deserializers. I added serializers of the ReferenceXXX form. This way, elements can be passed in as parameters. Added read/write graphson tests in Python to verify serialization/deserialization behavior.

----


> Detached side-effects aren't attached when remoted
> --------------------------------------------------
>
>                 Key: TINKERPOP-1679
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1679
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: language-variant, server
>    Affects Versions: 3.2.4
>            Reporter: stephen mallette
>
> This problem is exemplified in gremlin-python:
> {code}
> >>> vFrom = g.V(1).next()
> >>> vTo = g.V(6).next()
> >>> g.withSideEffect("t",vTo).V(vFrom).as_("f").addE("knows").from_("f").to("t").toList()
> {code}
> the {{vTo}} doesn't attach when it reaches the server, so when the {{addE()}} gets called you end up with a failure as it tries to add a detached vertex to a graph.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)