You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/22 18:49:29 UTC

[GitHub] [trafficcontrol] rob05c commented on issue #4657: Allow support for "If-Modified-Since" on GET requests

rob05c commented on issue #4657:
URL: https://github.com/apache/trafficcontrol/pull/4657#issuecomment-617963513


   >Does this fix #3509
   
   It doesn't look like it. It looks like it just adds IMS, not If-Unmodified-Since or If-Match.
   
   But it should make it much easier to, since it adds the modification logic necessary, should just be a matter of adding the header logic for IUS+IM.
   
   Same for ETags and If-None-Match, which allow more precise matching. I have a PR with the code for generating and matching ETags, it shouldn't be too difficult to integrate it with this:
   https://github.com/apache/trafficcontrol/blob/5379f97aed6d137cc79b8c517a5601fe3c02beeb/lib/go-rfc/cachecontrol.go


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org