You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by "henrysun007 (via GitHub)" <gi...@apache.org> on 2023/02/08 01:57:47 UTC
[GitHub] [incubator-teaclave] henrysun007 opened a new pull request, #676: Task logger
henrysun007 opened a new pull request, #676:
URL: https://github.com/apache/incubator-teaclave/pull/676
## Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
https://github.com/apache/incubator-teaclave/issues/669
The task logger part. Platform logging will be in another PR in a while.
## Type of change (select or add applied and delete the others)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [ ] Code cleanup or just sync with upstream third-party crates
## How has this been tested?
## Checklist
- [X] Fork the repo and create your branch from `master`.
- [X] If you've added code that should be tested, add tests.
- [X] If you've changed APIs, update the documentation.
- [X] Ensure the tests pass (see CI results).
- [X] Make sure your code lints/format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] mssun commented on pull request #676: Task logger
Posted by "mssun (via GitHub)" <gi...@apache.org>.
mssun commented on PR #676:
URL: https://github.com/apache/incubator-teaclave/pull/676#issuecomment-1430693485
The original design is to separate executors with other components to make it more flexible. In this implementation, if I understand correctly, executors are talking to the storage directly. Why not return the logs with the function return value instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] henrysun007 merged pull request #676: Task logger
Posted by "henrysun007 (via GitHub)" <gi...@apache.org>.
henrysun007 merged PR #676:
URL: https://github.com/apache/incubator-teaclave/pull/676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] henrysun007 commented on pull request #676: Task logger
Posted by "henrysun007 (via GitHub)" <gi...@apache.org>.
henrysun007 commented on PR #676:
URL: https://github.com/apache/incubator-teaclave/pull/676#issuecomment-1430735453
Keeping the logs persistent is good for audit. The log is more a supplement to `TaskState` that is persistent in the `storage` service than just a `diagnosis` tool for developers here. Let me have a think and we can achieve both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org