You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/02/20 15:50:48 UTC
[GitHub] couchdb-fauxton pull request: Remove raf
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/279
Remove raf
Garren and me tried to use the latest layoutmanager in summer
2014 - the experiment lead to performance improvements regarding
the rendering of our application, but we had to disable it as we
as it lead to timing issues.
As we are moving to React it does not make sense to me to invest
further time into the issues we had in summer.
This commit removes the leftovers of the experiment that are not
needed any more and cleans up.
See apache#29
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton remove-raf
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/279.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #279
----
commit afc3ed6032b96b00312f5488ad5488c469ba0d5c
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-02-20T13:12:35Z
backbone.layoutmanager@0.9.5
src: https://raw.githubusercontent.com/tbranyen/backbone.layoutmanager/0.9.5/backbone.layoutmanager.js
commit f7dec4064bfafe45faa19b4dfee1b3dd64d24dbe
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-02-20T13:14:56Z
cleanup: remove useRAF leftovers
Garren and me tried to use the latest layoutmanager in summer
2014 - the experiment lead to performance improvements regarding
the rendering of our application, but we had to disable it as we
as it lead to timing issues.
As we are moving to React it does not make sense to me to invest
further time into the issues we had in summer.
This commit removes the leftovers of the experiment that are not
needed any more and cleans up.
See https://github.com/apache/couchdb-fauxton/pull/29
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Remove raf
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/279#issuecomment-75533111
merged as 5752c486289ab75e7d6d282bff0c7130e45ab2ec and be661fb11f657700af2c524ff2626da680617698
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Remove raf
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/279#issuecomment-75505808
This fix needs to be applied to get the tests working
```diff
diff --git a/app/addons/documents/tests/nightwatch/bulkDelete.js b/app/addons/documents/tests/nightwatch/bulkDelete.js
index aeb1651..bc43ba9 100644
--- a/app/addons/documents/tests/nightwatch/bulkDelete.js
+++ b/app/addons/documents/tests/nightwatch/bulkDelete.js
@@ -59,7 +59,7 @@ module.exports = {
.click('#next')
.waitForElementVisible('[data-id="27"]', waitTime, false)
.click('#previous')
- .waitForElementPresent('.control-select-all.js-headerbar-togglebutton-selected', waitTime, false)
+ .waitForElementPresent('.js-headerbar-togglebutton-selected', waitTime, false)
.end();
}
};```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Remove raf
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/279#issuecomment-75267475
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Remove raf
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Remove raf
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/279#issuecomment-75270466
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Remove raf
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/279#issuecomment-75530600
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---